Approved :)

Thanks for the feedback!

Yep, testing for randomness was something I wanted to challenge myself in. Will do my best to refine the testing and learn from my errors.

Thank you for that! Other than those syntax errors, do you have any more feedback regarding the kata? :)

As many already stated, this needs a lot more random tests and a few initial test cases.

Great kata!

This was a good kata! Thank you :)

Part 1 & Part 2 solved! Thanks for the fun katas :)

Hey Johan,

I just starting using the Javascript translation, I notice that I got 50 errors all in the second-half of the idenity random test cases.

I printed the input of one of them here:

  90,
  98,
  54,
  46,
  99,
  27,
  76,
  74,
  70,
  91,
  82,
  99,
  1,
  19,
  15,
  1,
  38,
  39,
  48,
  72,
  90,
  98,
  54,
  46,
  99,
  27,
  76,
  74,
  70,
  91,
  82,
  99,
  1,
  19,
  15,
  1,
  38,
  39,
  48,
  72,
  90,
  98,
  54,
  46,
  99,
  27,
  76,
  74,
  70,
  91,
  82,
  99,
  1,
  19,
  15,
  1,
  38,
  39,
  48,
  72,
  90,
  98,
  54,
  46,
  99,
  27,
  76,
  74,
  70,
  91,
  82,
  99,
  1,
  19,
  15,
  1,
  38,
  39,
  48 ]```
  
  The expected output of that test case turns out to be: 
  ```[90, 99, 72, 98, 54, 46, 27, 76, 74, 70, 91, 82, 1, 19, 15, 38, 39, 48, 99, 1, 90, 99, 72, 98, 54, 46, 27, 76, 74, 70, 91, 82, 1, 19, 15, 38, 39, 48, 99, 1, 90, 99, 72, 98, 54, 46, 27, 76, 74, 70, 91, 82, 1, 19, 15, 38, 39, 48, 99, 1, 90, 99, 72, 98, 54, 46, 27, 76, 74, 70, 91, 82, 1, 19, 15, 38, 39, 48, 99, 1]```
  
  Is the output suppose to be ordered different from the initial input? Seems odd to me for an identity test case.

Needs a lot of random test cases.

Edit: I just submitted a Ruby translation for your kata. Please review and approve.

Cheers!

Yep, I noticed it as soon as you told me to check the input data earlier :)

That's updated!

I agree! I moved that bullet point over to the Battle Progress Rules.

Reading the description is already mentally taxing enough without the confusion! ;)

Kata has been updated with a set of random tests!

Thank you :D

Javascript translation submitted! Please review and approve it :)

Cheers!

Javascript translation sent! Please review and publish it :)

Cheers!