python new test framework is required. updated in this fork

Odds of winning and odds of max profit are calcualted incorrectly. It is assumed each bet results in profit. The last test shows that this is not always the case.

• NO random tests in C#

• Assert.AreEqual should be used

• Description uses Ruby syntax only (for every language).
• It is not clear that we are supposed to create methods "take" and "takeWhile", or whether they are preloaded for us to use.

Needs random tests.

A game map is represented by a 2d array containing only integers, and can be a grid of any size. Each number in the 'map' represents an entity

Actual test throws in jagged arrays like [[0, 1, 0, 0], [0], [0, 0]] which is not a grid.

Test setup is horrendous: it calls the function with the same arguments multiple times instead of reusing the result, reuses the same object for this, and uses Test.expect with no test feedback.

This also means modifying input object will break the tests.

There are already like a million basic pathfinding katas already approved. This kata is basically a duplicate.

I suggest fixing a few sentences in the Instructions for clarity. My suggested versions are below:

-If the player has at least 6 more power than the enemy (including modifiers), the player automatically wins, as the enemy's combat score couldn't possibly exceed the player's.

-If the player has less power than the enemy (including modifiers), the player can only win if the enemy rolls low enough for the player to have a chance. In this instance, the method should return a range equal to the ENEMY’s dice rolls which would give the player a chance to win.

C translation (author inactive)

( Haskell, possibly others )

Description is horribly underspecified. Expected outputs include "f(x) = ", "f(x) = x + -1", "f(x) = -1x + -1", which is not intuitive and not specified.

Is a constant function even linear? This is arguable, so should also be explicitly specified one way or the other.

the description is using global variables (i)

My code fails a test under the heading "Totenham should now have 4 goals for":

Nope! -  Expected: 3, instead got: 4

right after the test

Test Passed: Value == 4

What is this second test supposed to check? Is the heading maybe missing some information as it seems to check something more than just how many goals Totenham has? The stderr log just gives

/runner/frameworks/ruby/cw-2.rb:60:in `block in describe': Nope! -  Expected: 3, instead got: 4 (Test::Error)
	from /runner/frameworks/ruby/cw-2.rb:46:in `measure'
	from /runner/frameworks/ruby/cw-2.rb:51:in `describe'
	from /runner/frameworks/ruby/cw-2.rb:202:in `describe'
	from main.rb:131:in `block in <main>'
	from /runner/frameworks/ruby/cw-2.rb:55:in `block in describe'
	from /runner/frameworks/ruby/cw-2.rb:46:in `measure'
	from /runner/frameworks/ruby/cw-2.rb:51:in `describe'
	from /runner/frameworks/ruby/cw-2.rb:202:in `describe'
	from main.rb:91:in `<main>'

• Ruby 3.0 should be enabled (Refer this & this for more detail)