Ad
  • Custom User Avatar

    Im happy there are bots that go and help for things like this! I fixed this, it might not have updated it yet though

  • Custom User Avatar

    Hello! I am a Codewars bot, and I reviewed your kata for common authoring mistakes.

    Click to see the review

    Commonly occurring issues

    • ☠️ Assertions are placed incorrectly: In the example tests, all test.assert_equals calls are placed directly inside the function decorated with @test.describe("The Laughing Cipher") and are not wrapped in any @test.it block. For example, test.assert_equals(laugh_encode("hi!"), "ahhahaaaahhahaahaahaaaah") is executed at describe scope instead of inside an it, which goes against the expected describe/it structure; each assertion should be moved into one or more @test.it blocks.
    • 🛑 No debugging info on failure: In the submission tests, the @test.it("Fixed tests") block uses test.assert_equals without assertion messages and the it title doesn't include the tested inputs. For example, calls like test.assert_equals(laugh_encode("hi!"), "ahhahaaaahhahaahaahaaaah") give no indication of what input caused a failure when they break. Please add messages (e.g. ..., "Testing with 'hi!'") or include the input in the it titles so that failing cases are easier to debug.

    Please mind that I am not a very smart bot, and you should verify my remarks with any resources available for kata authors and translators:

  • Custom User Avatar

    That's nice code. In my code I seperated the length check and will it bring you to where you started check, but after seeing your code, I realize this is more concise and still readable.

  • Custom User Avatar

    This comment is hidden because it contains spoiler information about the solution

  • Custom User Avatar

    I like how you started the output out as the hashtag on its own line. That makes it easier to read. Also, I seperated the return statements so it looks more readable, but it is definitely good to teach new Python users how to do a one line if/else return statement.