Loading collection data...
Collections are a way for you to organize kata so that you can create your own training routines. Every collection you create is public and automatically sharable with other warriors. After you have added a few kata to a collection you and others can train on the kata contained within the collection.
Get started now by creating a new collection.
"Random tests are quite predictable" or "Random tests are not really random"
Either of those?
Random tests aren't random enough.- That is the worst insult towards random tests I've ever heard on this platform :DMissing
chai.config.truncateThreshold = 0( or another reasonable value )Random tests aren't random enough.
There should randomly be testing for missing user, missing orders, empty orders, or good orders.
This should not pass the test suite
See comments in my solution:
getOrders().idis falsy but notundefinedmy code would bug out on
id = 0.getOrderDetails()returns errorsendEmail()returns errorother calls have to handle destructuring a missing parameter; these don't.
getUser()'s result is not usedOK, we call it in case it returns error, but it still seems useless. isn't there something useful it could do?
chargePayment(orderId, callback)takes itsorderIdfromgetOrderDetails, notgetOrders.This is inadequately specified. The example doesn't help.
Example and Submit tests are missing
chai.config.truncateThreshold = 0, leading to failure messages such asuserId 154: expected full workflow helper chain: expected [ 'details:3666', …(3) ] to deeply equal [ 'details:3666', …(3) ].This issue probably applies to the whole series.
The failure message should probably also state these are the arguments the
callbackwas called with, but I don't know, because the message isn't telling me. The list might also be composed of other things.Truncated actual and expected values often are the same, the tests should use
chai.config.truncateThreshold = 0Fixed
https://www.codewars.com/kata/reviews/6a2c53c40a539b58bb305d03/groups/6a2d962db368c8f84da5d9c2
(Node 12)
There's something to be said for specifying and strictly testing that contract. The error message could be better though. You're testing the number of arguments of the callback. I'd suggest to explicitly show exactly that.
Got the concern. Let me few time, I'll improve it.
I'll let know when finish it
Loading more items...