Loading collection data...
Collections are a way for you to organize kata so that you can create your own training routines. Every collection you create is public and automatically sharable with other warriors. After you have added a few kata to a collection you and others can train on the kata contained within the collection.
Get started now by creating a new collection.
not an issue (a suggestion at best)
fixed
This is a kata issue, right? Can somebody fix it?
What about the sample tests? Shouldn't they have an assertion message as well?
@heroicfun Please avoid editing directly in approved katas. Instead, create a fork with your changes so others can review them.
now it's not broken
fixed problem with using hashmap in user's code.
Edit: i change test cases directly on kata but not on this translation
Please don't approve languages you haven't got the required experience with. The current translation is deficient, and more importantly, broken.
Please, for the love of all the gods, stop using naked
assert_eq!and put in proper assertion messages!!!!!!!! (This goes out to all you reviewers out there: This is the first thing to check!)And yikes, this is a first: don't put any test code outside the test module! Users are unable to
use HashMapin their own code, wtf?!approved
pls review it and approve
added test with empty input
test with empty input (
"" -> []) is missing. it may not yet have been added to Python, but that's no reason not to have it here. all other languages ( should ) have it.Approved.
Approved.
Loading more items...