python new test framework is required. updated in this fork

Thanks :)

approved

Ruby 3.0 should be enabled.

The host identifier (unclear in the description) is obtained by the formula :

• ip and one_complement(mask)

Instruction unclear

255.255.255.225 from the test cases is not a valid net mask. Netmasks are all 1s followed by 0s. Valid netmasks have significant octets of 255, 254, 252, 248, 240, 224, 192, 128, or 0. 255.255.255.225 in binary is 11111111 11111111 11111111 11100001.

I find the description to be too much. You don't need to give all these information, they tend to scare people away and make them think the problem is harder than it really is. Let them do they research by themselves because I personally think this is part of the kata too: research. So please, consider removing all these info and just give some hints to them.

Absolutely loved this kata. Hadn't used bitwise operators before so nice to learn about that. Maybe something to add to the description would be "The host part can be derived by using bitwise AND of IP address and one's complement of the subnet mask." I'm not sure the description makes that clear. Approved!

Wops, thanks OZ!

I fixed a copypasta in the JS translation (ipv4__parser -> ipv4Parser). Great job, other than that!

And your wish was granted: feel free to have some test run and tell me if everything is ok with you and on par with your standards.

Thanks again for this nice kata :)

Nice, thank you. I approved them, and random tests for the Python version would be great. :-)

Translated into JS and Ruby, if you want to approve it :)

Let me know if you wish that I add the random tests to the Python version too :)

Hey staticor, I updated the kata with a new unit test; the solution should handle subnetting not limited to the final octet:

assert (ipv4__parser('65.196.188.53', '255.255.240.0') == ('65.196.176.0', '0.0.12.53'))