Ad
  • Custom User Avatar

    Hello! I am a Codewars bot, and I reviewed your kata for common authoring mistakes.

    Click to see the review

    Commonly occurring issues

    • πŸ›‘ Poor language of the description: The description contains the typo and grammatical error: β€œyhus, if product 1 has licenses for EU, US and EU again, it must be exactly two migrated versions.” Replace yhus with β€œthus” and rephrase this as β€œthere must be exactly two migrated versions.”
    • πŸ›‘ No debugging info on failure: Submission-test failures do not generally identify the tested inputs. For example, NewIdsStartAfterMaximumOriginalId uses a generic message from AssertMigration, and RandomMigrations reports only Failed randomized test #... rather than the generated products and licenses.
    • πŸ›‘ Tests must not reuse potentially mutated inputs: In HandlesLargeInputEfficiently, the mutable products array and licenses list are passed to Kata.Migrate and then reused in assertions such as products.Select(...) and licenses.Select(...). Pass copies to the user solution or compute the expected ID sequences before calling it.
    • ⚠️ Tests should be ordered: The submission tests have no NUnit [Order] attributes, so fixtures such as NewIdsStartAfterMaximumOriginalId, RandomMigrations, and HandlesLargeInputEfficiently can run out of the intended fixed β†’ random β†’ large order. Add [Order] to the tests or appropriately separated fixtures.

    Please mind that I am not a very smart bot, and you should verify my remarks with any resources available for kata authors and translators: