Can anyone tell me why in performance katas performance is not regarded? I mean this solution is heavy (#imho).
@FArekkusu it's a CW glitch as it only sets 3.8 as default after republishing twice (I've alr fixed most of my edits previously)
@ejini战神 next time you decide to update the kata to properly support Python 3.8, make sure that everything works correctly. All the katas which had issues raised about No module named 'codewars_test' were messed up by your edits.
No module named 'codewars_test'
Switch to Python 3.8.
Tests are broken in Python "ModuleNotFoundError: No module named 'codewars_test'". My code passes all basic tests.
added for python, ruby, CS (still missing for Java, Scala)
Random tests should be added.
This comment is hidden because it contains spoiler information about the solution
No random tests in (at least) Java, CoffeeScript, Python and Ruby.
when i tested my code i had got following error. Why?
solution.c:1:1: error: unknown type name 'y_'
In file included from solution.c:2:
In file included from /usr/lib/llvm-8/lib/clang/8.0.1/include/stdint.h:61:
In file included from /usr/include/stdint.h:27:
/usr/include/x86_64-linux-gnu/bits/types.h:30:1: error: expected identifier or '('
typedef unsigned char __u_char;
2 errors generated.
I think one fault is present in the tests.
First time I wrote in my code:
s = n*m
and all tests were complited. But, I think it is not good. Because, for exeple: if n and m are negative, result not will be 0 (I understand that pieces of chockolate can't be negative, but ...).
And I changed the code:
s = 0
Because, as for me, s = n*m is not true if n and m are negative