You're welcome.

Thank you! This was my first approved kata. I wanted to do something i enjoy and also needed to practice haha

Great kata on object oriented programming to practice with.

ready for approval: ranking votes

nice kata

wow good art

:D

beautiful

yup.

Some notes on the way:

• if randint(1,2) == 1: is equivalent to if randrange((2):
• for the outer if like the above (in the loop), you should probably use if not randrange(5), so taht the else case doesn't happen too often.
• Might also be good to add an inner loop, to retests several times each value of w (like 5 times each, for example)

I think i understand what you mean, and I made the changes, can you take a look?

looks good except for the fact the two batches of random tests should be merged into one (picking randomly one strategy or the other). Otherwise ['0'] * len(warehouse) can pass the second batch without actually implementing the logic.

hello, i added @test.it in random test, and add the sample test where the barrels are the size of the warehouse and in the random test too.

Thank you for your feedback =)

Hi,

• The assertions in the random tests should be inside a @test.it block, not directly inside a @test.describe one.
• Missing sample tests where the barrels are the size of the warehouse
• some random tests should also generate cases like that.

Cheers

.

In these cases, the barrels must be positioned in the last 2 positions on the list, as this is the smallest available space in which they fit. I think this is not clear in the description?

Ah, I modified the tests, the lists were being passed incorrectly, there was a possibility that they were modified and the tests could be bypassed. I made a copy of the lists so that the user cannot change them.