Ad
  • Custom User Avatar

    Resolved in this fork

  • Custom User Avatar

    Fixed in Python

  • Default User Avatar

    updated to F# 6.0 + NUnit, using tuples

  • Custom User Avatar

    added some time ago

  • Custom User Avatar

    funny how 4 others did it as well

  • Custom User Avatar

    Nice to hear, thank you!

  • Default User Avatar

    This comment is hidden because it contains spoiler information about the solution

  • Custom User Avatar

    I will write a usual review. the original translator is still around so I won't hijack the translation yet.

  • Custom User Avatar

    I can, later today or tomorrow.
    The solution setup looks good, so if you approve and problems are found, tests could be improved without invalidating solutions.
    After skimming briefly over the code of tests I did notice one or two WTFs, but nothing what couldn't be fixed after approval.

  • Custom User Avatar

    Thanks, I fixed the first issue, and I also attempted to patch up the fstring loop-hole. Let me know your feeback!

  • Custom User Avatar

    What's wrong with "eval"? While you have to deal with other problems except calculating strings as values, I think using "eval" is defntely okay.

    Evaluation at runtime of values provided by user is hardly ever a good idea, for many reasons, but main of them being security: it will wreak havoc if user solution returns something like "system(wipe_hdd)" or "apt_get install mymalware" etc. That's why eval should not accept user input, and when it does, the input must be properly sanitized. Except it's difficult, and users can obfuscate input in ways which pass sanity checks and still execute malicious code (for example a JSFu*k expression, or similarly obfuscated). Even if eval can be sometimes used safely with user input, it's difficult and it's just better not to.
    Calling eval with your own input, which is not derived in any way from user input, might be not that bad, but it's usually unnecessary: if it's you who builds the input, you usually already know how to evaluate it.
    There are also secondary reasons like performance, poor user experience, etc. but vulnerability to user-crafted malicious inputs is one of the main factors.

  • Custom User Avatar

    Yes. If you persist to change the description, I will delete that line.
    I've received lots of people telling me to read the Kata Authoring Guidlines, I've read it many times, ofc.
    Why think this kata won't get approved without seeing others' reactions? It is a humiliation for an author to unpublish a kata by himself, after spending hours creating it.
    Thank you for your suggestion. I hope to see you again. Have a nice day.

  • Custom User Avatar
    1. Yes. It's becuz you already can't use some Python modules in Codewars.
    2. At first I tried to use the module "py-expression-eval" but apparently Codewars doesn't support it.
    3. What's wrong with "eval"? While you have to deal with other problems except calculating strings as values, I think using "eval" is defntely okay.
    4. Yes. While most of the low-level katas are similar, IMO this kata is just a higher level of summation compared to other summation katas.
      I hope you can understand it.
  • Custom User Avatar

    approved by

  • Custom User Avatar

    Looks cool

  • Loading more items...