Hello everyone,

I added 4 extra test cases for single characters where str.isdigit is True, but the description tells us that we should return False.

In my opinion, this point is very important and the change would invalidate the highest voted solution.

In addition, I've refactored the test code to reduce repetition.

What do you think about my proposal?

Thank you very much in advance.

Best regards,
Thomas

approved

Sorry. Just fixed it.

it's still there in the solution setup (the initial solution)

Good point. I just removed the mentioned lines and some stuff that I just needed to test the code locally on my machine.

I am not very experienced in Perl, but this looks good. I have one question regarding the purpose of

use Exporter 'import';

our @EXPORT_OK = qw(greet);

that I do not see in other Perl kata. If I understand correctly, this allows the subrootine greet() to be used unqualified, but you never use that in the test suite, you qualify the identifier instead: Solution::greet(). What is your rationale for this ?

I followed your advice to create a Perl translation myself. I learned a lot.

I would be happy, if you find time to review it.

Thank you very much in advance.

Best regards,
Thomas

if you click on the translator's profile you can see that he has not logged in 3 years. If you are proficient in Perl and would like to see a Perl translation to this kata, you can write one yourself, as this one seems to be a draft that never got completed, as you noticed. I am rejecting it for these reasons

Dear translator,

as far as I can see, the solution is missing a final line to return a truthy value.

1;

However, the sample test cases do not seem to have any connection to the problem. I assume, that we just need to copy the test cases to the sample test cases.

I recommend to use perlcritic to find potential problems in Perl code.

I hope, that my remarks are helpful.

Best regards,
Thomas

I hadn't thought of 1 occurring multiple times in the sequence, so having multiple predecessors.

Better. :]

Hello Johan,

thanks for your feedback. I've made some adaptions according to your suggestion. Is this improving the description in your opinion?

Best regards,
Thomas