7 kyu
'x' marks the spot.
1,920 of 2,280user4386369
Loading description...
Fundamentals
Arrays
Matrix
This comment has been reported as {{ abuseKindText }}.
Show
This comment has been hidden. You can view it now .
This comment can not be viewed.
- |
- Reply
- Edit
- View Solution
- Expand 1 Reply Expand {{ comments?.length }} replies
- Collapse
- Spoiler
- Remove
- Remove comment & replies
- Report
{{ fetchSolutionsError }}
-
-
Your rendered github-flavored markdown will appear here.
-
Label this discussion...
-
No Label
Keep the comment unlabeled if none of the below applies.
-
Issue
Use the issue label when reporting problems with the kata.
Be sure to explain the problem clearly and include the steps to reproduce. -
Suggestion
Use the suggestion label if you have feedback on how this kata can be improved.
-
Question
Use the question label if you have questions and/or need help solving the kata.
Don't forget to mention the language you're using, and mark as having spoiler if you include your solution.
-
No Label
- Cancel
Commenting is not allowed on this discussion
You cannot view this solution
There is no solution to show
Please sign in or sign up to leave a comment.
python translation
Approved
Random test only generates nested list consisting of only 1
xs inC
JS
Julia
was not true in C. fixed in JS.
CoffeeScript translation
Approved
it was great
i loved this kata :)
This comment has been hidden.
Fixed.
Really Nice!!
Added Golang translation
I added some remarks on the translation page.
Wrote an answer.
Added Julia translation
Do you want review my golang translation?
approved
Edit: raised an issue above
C description is inconsistent with the example test cases:
If 'x' is not inside the array, or if 'x' appears multiple times return {-1, -1}but examples return an empty array for either of those conditions.
ok, i plastered the whole markdown with
```if:c ...🤷This comment has been hidden.
your code is incorrect; it cannot handle cases where a there are multiple
'x's in a row, but only one row with'x's present :/COBOL translation + description corrected according to actual tests (no empty array tested, only 'x' and 'o' are included in the tested arrays).
merge conflict (even before approving Julia just now)
Yeah, the description is a mess... I'll need to have a look at this cautiously and approve myself. Thanks for the review.
This comment has been hidden.
Fixed
Take care of what you modify, I think description and tests are now different. Revert the changes.
My bad, you're indeed correct. Thanks for notifying me. Changes have been reverted.
C translation (author left codewars)
Approved :)
Hmmm... Approved but I forgot my description's update in COBOL translation (see above). In JS the arrays only contain 'x' and 'o'. I stuck with it in my translation and updated the description in my fork. Maybe you should do it too in C and change the description accordingly, or we are going to have another messy kata with incoherent translations.
should I edit the kata's description directly then ?
I don't know if it makes a difference editing the descripition or publishing a new fork. Do as you prefer.
okay, I did as you said. removed characters other than x and o from C, and modified the description
Return value logic feels forced. Why not return an array of solutions if there is more than one?
Now you see everybody special-casing for multiple solutions. It's not bad but it's not elegant either.
Yeah, it's weird.
This comment has been hidden.
Random Tests added.
Random test needed
Random tests added.