7 kyu
Sentence to words
686 of 1,519wichu
Loading description...
Fundamentals
View
This comment has been reported as {{ abuseKindText }}.
Show
This comment has been hidden. You can view it now .
This comment can not be viewed.
- |
- Reply
- Edit
- View Solution
- Expand 1 Reply Expand {{ comments?.length }} replies
- Collapse
- Spoiler
- Remove
- Remove comment & replies
- Report
{{ fetchSolutionsError }}
-
-
Your rendered github-flavored markdown will appear here.
-
Label this discussion...
-
No Label
Keep the comment unlabeled if none of the below applies.
-
Issue
Use the issue label when reporting problems with the kata.
Be sure to explain the problem clearly and include the steps to reproduce. -
Suggestion
Use the suggestion label if you have feedback on how this kata can be improved.
-
Question
Use the question label if you have questions and/or need help solving the kata.
Don't forget to mention the language you're using, and mark as having spoiler if you include your solution.
-
No Label
- Cancel
Commenting is not allowed on this discussion
You cannot view this solution
There is no solution to show
Please sign in or sign up to leave a comment.
This should be in 8kyu
This comment has been hidden.
This comment has been hidden.
python new test framework + random tests are required. updated in this fork
This problem should be translated to english first, cuz it's dead language
Should definitely be 8kyu
Agree
Me likey.
Python version still uses camelCase despite what was said below.
It is not explained what a "word" is.
No random tests.
(JS and Python) I know you don't want to add punctuation since it is simple kata, but how about some random test cases without it?
Re-raised as an issue.
Kumite for Python translations up. Would it be worth me adding test cases involving punctuation etc? I haven't yet as it would involve changing the Kata Description...
I cn't see 'aprove' button - please give me a link to aproval your transaltion. Theres no need for tests for punctuation. I'll leave this kata as simple as it is now.
This comment has been hidden.
@Blackmetalmcdonalds
,https://www.python.org/dev/peps/pep-0008/#function-names
splitSentence -> split_sentence
Needs random test cases
Thanks!
@zebulan
thanks for pointing out camel case, I hadn't noticed it.I have fixed this and added random tests. This was my first translation and I seem to have made a mess of it...
I have edited my translation. I'm not sure if
@wichu
needs to approve?@Blackmetalmcdonalds
,No problem, I was just trying to help out.
A lot of users (including myself!) come to Codewars to learn and I just think we can all help each other by writing code that follows a languages style and naming conventions. I picked up some bad habits when I was first learning Python and I have found the PEP8 (and other) warnings on PyCharm have really helped me write cleaner code.
Thanks for the fix!
A few more test cases, and random ones would be nice. The kata could be more interesting or challenging if the user had to remove any punctuation in the middle of the sentence (commas, semicolons, etc).
It's 8 kyu kata, so it covers only basic scenario. Simple 3 minute exercise.
Not an excuse for the totally inadequate testing.
Fully agree on this being 8 kyu - enjoy the cheap points, solvers.