7 kyu
It is written in the stars
2,228 of 2,535St3f4n
Loading description...
Date Time
Puzzles
.avif)
This comment has been reported as {{ abuseKindText }}.
Show
This comment has been hidden. You can view it now .
This comment can not be viewed.
- |
- Reply
- Edit
- View Solution
- Expand 1 Reply Expand {{ comments?.length }} replies
- Collapse
- Spoiler
- Remove
- Remove comment & replies
- Report
{{ fetchSolutionsError }}
-
-
Your rendered github-flavored markdown will appear here.
-
Label this discussion...
-
No Label
Keep the comment unlabeled if none of the below applies.
-
Issue
Use the issue label when reporting problems with the kata.
Be sure to explain the problem clearly and include the steps to reproduce. -
Suggestion
Use the suggestion label if you have feedback on how this kata can be improved.
-
Question
Use the question label if you have questions and/or need help solving the kata.
Don't forget to mention the language you're using, and mark as having spoiler if you include your solution.
-
No Label
- Cancel
Commenting is not allowed on this discussion
You cannot view this solution
There is no solution to show
Please sign in or sign up to leave a comment.
Python (maybe others): 1400+ random tests are not necessary; furthermore, the description says 100 random tests...
1400 full random tests are pointless, for sure. This is related to an issue already raised below. Tests for this kata should just make sure each possible day of the year is checked, since it's feasible easily and at the same time necessary to ensure passed solutions are valid without omitting any edge case. All languages should stick with this and the description should be changed.
COBOL translation.
approved
Python: Despite a huge number of tests (1400), random tests are not random...
The test cases aree wrong Test.assertEquals(starSign(new Date(1970, 5, 5)), 'Gemini'); - it's not 'Gemini', it's Taurus Test.assertEquals(starSign(new Date(2000, 1, 15)), 'Aquarius') ;it's not 'Aquarius', it's Capricorn Test.assertEquals(starSign(new Date(1987, 7, 23)), 'Leo');
The test cases aree wrong
Wrong how?
Test.assertEquals(starSign(new Date(1970, 5, 5)), 'Gemini'); 5th of May will be Taurus, not Gemini.
That evrywere. JS.
Link to Discussion
Resolving as this is not a kata issue JustJSThings
The first basic test is:
Test.assertEquals(starSign(new Date(1970, 5, 5)), 'Gemini');
But the details say that: Taurus -------- 21 April - 21 May Gemini -------- 22 May - 21 June
Unless, I'm going insane and missed something, 5th May falls under Taurus, not Gemini.
Think a lot of the test cases are wrong.
I tried for a long time and also thought I am going insane :D Dear author - PLEASE fix test cases.
Don't work: Expected: 'Taurus', instead got: 'Aries" Date: 2011 - 3 - 3 (3 april 2011)
Python translation, please check and approve
Done :)
All days of the year should be tested.
Done for COBOL. Now the description is incorrect + there's an issue in Python tests (see above).
2 of the 3 testcases seem to be wrong.
May 5th is taurus, not gemini.
January 15th is capricorn, not aquarius.
Month in JS
Dateis 0 indexed so you're referring to 5th June and 15th February, so everything's ok.Thanks!
Typo in description: 'Saggitarius' should be 'Sagittarius'.
Fixed...