6 kyu
Dictionary of Factors
429Climacus
Loading description...
Algorithms
Fundamentals
View
This comment has been reported as {{ abuseKindText }}.
Show
This comment has been hidden. You can view it now .
This comment can not be viewed.
- |
- Reply
- Edit
- View Solution
- Expand 1 Reply Expand {{ comments?.length }} replies
- Collapse
- Spoiler
- Remove
- Remove comment & replies
- Report
{{ fetchSolutionsError }}
-
-
Your rendered github-flavored markdown will appear here.
-
Label this discussion...
-
No Label
Keep the comment unlabeled if none of the below applies.
-
Issue
Use the issue label when reporting problems with the kata.
Be sure to explain the problem clearly and include the steps to reproduce. -
Suggestion
Use the suggestion label if you have feedback on how this kata can be improved.
-
Question
Use the question label if you have questions and/or need help solving the kata.
Don't forget to mention the language you're using, and mark as having spoiler if you include your solution.
-
No Label
- Cancel
Commenting is not allowed on this discussion
You cannot view this solution
There is no solution to show
Please sign in or sign up to leave a comment.
python new test framework is required. updated in this fork
Approved
not facors but divisors.
The function name should be in snake_case.
Fixed in latest fork
Hi,
Typo in the second line of the description (I suppose) : "directory" instead of "dictionary".
About the kata itself, this seems not logical to store ['None'] instead of a simple empty list when the number is prime:
if no factor, len(list) == 0makes more sens/be better practice thanif no factor, len(list) == 1 and lst[1] == 'None'. I think you should modified your kata about this point.Regards,
B4B
Description could be clarified in two ways:
1 Clarification of the purpose of values
nandm.2 Be explicit that 1 and the number itself are excluded from the list of factors.
Thanks for the feedback. I've adjusted the kata description. I appreciate the input!
Consider adding random test cases
Thank you for the input. I've gone in and created a set of random test cases. Much appreciated!