Beta

Aliens have landed

Description
Loading description...
Fundamentals
Strings
  • Please sign in or sign up to leave a comment.
  • hobovsky Avatar
    • Tests should not print to stdout if not necessary. Instead of printing, inputs can be presented with test headers or custom assertion messages on failure.
    • Tests should be organized properly with describe and it blocks, and updated to the latest version of Node used by Codewars.
    • Suggested tests for edge cases: input with nothing but vowels, inputs with only vowels, sentences with only one word, empty string (if valid).
  • JohanWiltink Avatar

    It's approvable. But is it ( still ) original?

  • FArekkusu Avatar

    Also, there should be fixed tests with uppercase vowels.

    • MHUS25 Avatar

      I've added fixed tests with uppercase vowels. Thanks for your suggestion.

      Suggestion marked resolved by MHUS25 7 years ago
  • FArekkusu Avatar

    No random tests.

  • Chrono79 Avatar

    The function in inital code has no parameters (there is an empty string there). Write messageor any other meaningful name there. Only two tests are not enough.

  • hobovsky Avatar

    Define 'vowels'. For example, 'y' is a vowel in some languages, and in some others it is not. What are vowels in the language of the Aliens?

    • FArekkusu Avatar

      Currently there're no tests with letter "y".

      Also it's English -> Alien, not Alien -> English, so the question is whether we should considers "y" as a vowel in English.

    • MHUS25 Avatar

      This has been resolved now. Thanks for your question.

      Question marked resolved by MHUS25 7 years ago