Retired

Convert recurring decimal to fraction (retired)

Description
Loading description...
Mathematics
Fundamentals
View
AllIssues4QuestionsSuggestionsShow Resolved
  • Please sign in or sign up to leave a comment.
  • davilla Avatar

    Not only does this kata not do a thorough job of testing, I suspect the solution tested against to be wrong. I just ran all of the other verified solutions against this:

    convert(0.909, '09')  # expect 10/11
    convert(0.90, '90')  # expect 10/11
    

    and none of them give the right result for the second line. To be fair, one works correctly when passing in 0.9090 and another with 0.909090, but partial credit isn't quite the same thing as correct, is it?

    Although my inital solution accidentally passes on this test, there are similar cases where it failed. I know how to patch my code, if only there were a way to edit a submission without resubmitting a new one. That' just brilliant. I've resubmitted my patched code and forked too. Not sure the difference.

  • rnelsonee Avatar

    I haven't been on codewars long, but I feel like any kata that requires importing modules shouldn't be 8 or 7 kyu. Or there should be a mention of the module to import in the description.

  • krishp Avatar

    How would someone use a while loop in python for a kata like this?

  • ZED.CWT Avatar

    Lack of cases like

    0.8088,'8'
    65.666,'6'
    
    • joelpeyton Avatar

      Ha that, second test has exposed a flaw in my solution. We get different answers for that case, when I run them side by side, so I'm going to assume yours is the better solution.

    • joelpeyton Avatar

      OK my solution works for 0.8088 and 65.666, but only if the recurring part is shown as '88' and '66' respectively. This I did know when testing against similar test cases and I made allowances for it by doubling up the recurring digit.

      Your solution doesn't require it.

    • joelpeyton Avatar

      This comment has been hidden.

      Issue marked resolved by joelpeyton 6 years ago
  • ZED.CWT Avatar

    Needs Random Tests.

    • joelpeyton Avatar

      Thanks for feedback, as you'll have noticed this is my first attempt at creating a kata, curious as to how I can go about generating random tests, or do I literally generate a list of random recurring decimals, and run them through my algo to get correct results?

    • ZED.CWT Avatar

      Well, the common setup could be

      func ref(){} | Your solution
      
      for 100 times
      {
          input = generated()
          expected = ref(input)
          AssertEquals(usersolution(input),expected)
      }
      
    • joelpeyton Avatar

      Updated test cases

      Issue marked resolved by joelpeyton 6 years ago