Retired
Imperial fractions (retired)
Loading description...
Fundamentals
This comment has been reported as {{ abuseKindText }}.
Show
This comment has been hidden. You can view it now .
This comment can not be viewed.
- |
- Reply
- Edit
- View Solution
- Expand 1 Reply Expand {{ comments?.length }} replies
- Collapse
- Spoiler
- Remove
- Remove comment & replies
- Report
{{ fetchSolutionsError }}
-
-
Your rendered github-flavored markdown will appear here.
-
Label this discussion...
-
No Label
Keep the comment unlabeled if none of the below applies.
-
Issue
Use the issue label when reporting problems with the kata.
Be sure to explain the problem clearly and include the steps to reproduce. -
Suggestion
Use the suggestion label if you have feedback on how this kata can be improved.
-
Question
Use the question label if you have questions and/or need help solving the kata.
Don't forget to mention the language you're using, and mark as having spoiler if you include your solution.
-
No Label
- Cancel
Commenting is not allowed on this discussion
You cannot view this solution
There is no solution to show
Please sign in or sign up to leave a comment.
The current sample test is incorrect:
That's about
16.77inches, so it should be1ft 5in.THX sorry for this one - bad copy/paste :/
I have added more tests - including 0, missing in/fract and carrying
Shouldn't 0 be
0inor something?Sample tests is different from actual tests, which is a bad idea.
The edge cases are also either missing or only exists in sample tests, such as missing
ft,inor fractionalin, and carrying.Needs random tests.
THX. Please let me know what you mean with 'random' (sorry for the dumb question - my first try here). I woudl not think I need to test for the inputs being something else than positive numbers / integer do I ?
Random tests means tests with inputs randomly generated at runtime, typically 100 tests per run.
You should definitely check out the existing katas on how random tests are done ;-)
@marmotteNZ you may find this useful (though it's in JS, not Python)
EDIT: Additionally, since you mentioned that this Kata was your "first try", you may want to read "Creating your first Kata" carefully in order to better understand what the CW community expects of Kata authors, cheers :-)