6 kyu
Length Factorial Encryption
69 of 116ozichukwu
Loading description...
Algorithms
Parsing
Fundamentals
This comment has been reported as {{ abuseKindText }}.
Show
This comment has been hidden. You can view it now .
This comment can not be viewed.
- |
- Reply
- Edit
- View Solution
- Expand 1 Reply Expand {{ comments?.length }} replies
- Collapse
- Spoiler
- Remove
- Remove comment & replies
- Report
{{ fetchSolutionsError }}
-
-
Your rendered github-flavored markdown will appear here.
-
Label this discussion...
-
No Label
Keep the comment unlabeled if none of the below applies.
-
Issue
Use the issue label when reporting problems with the kata.
Be sure to explain the problem clearly and include the steps to reproduce. -
Suggestion
Use the suggestion label if you have feedback on how this kata can be improved.
-
Question
Use the question label if you have questions and/or need help solving the kata.
Don't forget to mention the language you're using, and mark as having spoiler if you include your solution.
-
No Label
- Cancel
Commenting is not allowed on this discussion
You cannot view this solution
There is no solution to show
Please sign in or sign up to leave a comment.
python new test framework is required. updated in this fork
Minor correction in the description: when you're explaining the pattern in the key, you say the first character is the 17th, but you mean the 18th.
Also, this is not as important, but the way you switch how you describe the position in the string is a little strange.
Sorry if this seems nitpicky, I just saw something so I figured I'd say something
Thanks for pointing it out. I've corrected it.
Performance requirements are still not mentioned anywhere, and the random test generation is terribly slow in Python. Seriously, why the hell are you testing such long strings?
The point isn't about the length of strings. It's about how fast your code can decipher the encrypted message regardless of its length
If you want to forbid slow solutions, test their time complexity (is there even a way to do this slower than in
O(n * log(n))?). Microoptimization is generally considered more tedious than interesting/challenging; and that's when the tests are properly implemented, because here even "slow" solutions can pass easily.I understand you now. I've removed unneccesarily long strings and set constraints for which a solution must handle to pass the tests.
Thanks a lot for contributing. I could really learn a lot from you.. +1 follower to you.
New Python test framework should be used.
done
Sample tests are still using old framework.
fixed bro
Python 3.6 must be enabled.
Python 3.6 isn't supported and I can't seem to find the docs of this new test framework you talk of. Certainly not in https://www.codewars.com/docs/python-test-reference-1
wut? :o
test framework: https://github.com/Codewars/codewars.com/wiki/Codewars-Python-Test-Framework-V2
Python 3.6 enabled :)))
There should be short random strings for easier debugging, and the performance requirements should be mentioned in the description. Although, I don't see any point in the such long inputs at all.
"short random strings for easier debugging" added. Thanks for correcting.
The link to the repository should be removed.
done
The "random" tests are not random at all.
And inadequately few.
But you have my unconditional downvote for selling fixed tests as randoms. You realise we can read your tests, don't you? ( after solving ) :S
Even without solving the kata it becomes evident after a few attempts anyway, so it's not like you need to read the tests to figure that out.
Thanks for the feedback. I've made some changes. More feedbacks would be appreciated :)
No sample tests.
Solved. Thanks for your feedback