6 kyu
Gregorian to Islamic Calendar Converter
32 of 36hibrahimag1
Loading description...
Fundamentals
Strings
View
Career Accelerator
This comment has been reported as {{ abuseKindText }}.
Show
This comment has been hidden. You can view it now .
This comment can not be viewed.
- |
- Reply
- Edit
- View Solution
- Expand 1 Reply Expand {{ comments?.length }} replies
- Collapse
- Spoiler
- Remove
- Remove comment & replies
- Report
{{ fetchSolutionsError }}
-
-
Your rendered github-flavored markdown will appear here.
-
Label this discussion...
-
No Label
Keep the comment unlabeled if none of the below applies.
-
Issue
Use the issue label when reporting problems with the kata.
Be sure to explain the problem clearly and include the steps to reproduce. -
Suggestion
Use the suggestion label if you have feedback on how this kata can be improved.
-
Question
Use the question label if you have questions and/or need help solving the kata.
Don't forget to mention the language you're using, and mark as having spoiler if you include your solution.
-
No Label
- Cancel
Commenting is not allowed on this discussion
You cannot view this solution
There is no solution to show
Please sign in or sign up to leave a comment.
JS translation (author active)
Thanks for translating, as well as approving the kata! I'm very grateful
Test cases and reference solution has incorrect leap year check.
You should put your leap year check into the kata you linked and see what's wrong with it ;-)
Hi, I changed my leap year check according to the linked kata. Please review :)
Needs a test case of
29/2on a leap year. This does not exist in fixed tests, and random tests never generates them.Hi, I added a fixed test case with 29/2/4. I also added random tests that generate the date 29/2 in some leap year. Please review :)