6 kyu
Seven-segment display: how many switches?
43alexc19
Loading description...
Fundamentals
View
This comment has been reported as {{ abuseKindText }}.
Show
This comment has been hidden. You can view it now .
This comment can not be viewed.
- |
- Reply
- Edit
- View Solution
- Expand 1 Reply Expand {{ comments?.length }} replies
- Collapse
- Spoiler
- Remove
- Remove comment & replies
- Report
{{ fetchSolutionsError }}
-
-
Your rendered github-flavored markdown will appear here.
-
Label this discussion...
-
No Label
Keep the comment unlabeled if none of the below applies.
-
Issue
Use the issue label when reporting problems with the kata.
Be sure to explain the problem clearly and include the steps to reproduce. -
Suggestion
Use the suggestion label if you have feedback on how this kata can be improved.
-
Question
Use the question label if you have questions and/or need help solving the kata.
Don't forget to mention the language you're using, and mark as having spoiler if you include your solution.
-
No Label
- Cancel
Commenting is not allowed on this discussion
You cannot view this solution
There is no solution to show
Please sign in or sign up to leave a comment.
Pretty challenging kata of the series, nice one.
Hi,
Cheers
Thanks, test cases updated. Had to move the helpers back to higher scope, hope it's ok, otherwise I could further abstract the test configuration.
errrr... the new overall setup looks good, but:
One digit, sequence is just one number
batch of tests should also be present in the example testsNote that you still have some duplicated code in there (nothing critical). My idea was more along the line of:
The same could be done for the ixed tests, but they are good enough already, I guess.
I can make also the title a parameter, my thinking was that explicitly mentioning the tile in @test.it makes the test cases source a bit more readable, though less compact.
"One digit, sequence is just one number" batch of tests should also be present in the example tests" => isn't that too much help?
Total number of random tests has not changed, I have 10x runs for the most complex kind, could run 10x for each kind, I just thought we could save a bit of computational power.
well, depends. But adding those tests was the very first thing I did to debug my code. I didn't even try to use the actual sample tests. So, yeah, "might be too much", but on the other hand, not having them feels sometwhat like taking the users for fools (as in "yeah, I made a kata, but I won't provide you the actually useful tests). Side note: if the tests are in the full test suite, there is no valid reason to not put them in the example tests, imo. ;)
you can leave aside the two other points, if you want.
It's an interesting debate, writing a few tests of your own as a user could be regarded as part of solving the kata, but I see your point.
I updated the example tests and refactored the random test cases 👍
It is not clear from the description:
size
parameter (left padding " ")Thanks for your feedback, I've updated the description to clarify both points.
This comment has been hidden.
Fixed, thanks!
Super cool kata; enjoyed solving!