7 kyu
Highest Value Pyramid
245 of 370Joachim10
Loading description...
Fundamentals
.avif)
This comment has been reported as {{ abuseKindText }}.
Show
This comment has been hidden. You can view it now .
This comment can not be viewed.
- |
- Reply
- Edit
- View Solution
- Expand 1 Reply Expand {{ comments?.length }} replies
- Collapse
- Spoiler
- Remove
- Remove comment & replies
- Report
{{ fetchSolutionsError }}
-
-
Your rendered github-flavored markdown will appear here.
-
Label this discussion...
-
No Label
Keep the comment unlabeled if none of the below applies.
-
Issue
Use the issue label when reporting problems with the kata.
Be sure to explain the problem clearly and include the steps to reproduce. -
Suggestion
Use the suggestion label if you have feedback on how this kata can be improved.
-
Question
Use the question label if you have questions and/or need help solving the kata.
Don't forget to mention the language you're using, and mark as having spoiler if you include your solution.
-
No Label
- Cancel
Commenting is not allowed on this discussion
You cannot view this solution
There is no solution to show
Please sign in or sign up to leave a comment.
are u sure this is 7 kyu ?
Very nice. Very nice.
I am noob in programming, passed some harder challenges before, but maaan, it took me many-many hours to figure out, absolutely drove me crazy and felt the best when passed all tests, awesome kata. Thanks!
This seems too complex for a 7 kyu, I think it should be 6 kyu.
LC translation
This translation modifies the description. The Java translation does not - approve that one first.
Java translation
Javascript translation
Haskell translation
Approved by non-author.
It's better to create a separate block and display the input array of random tests for easier debugging. fork for this
approved by original author.
@saudiGuy Yes, thank you. I looked up the improved code on my phone and I unwittingly approved the solution, so I didn't notify you. I wanted to accept it anyway; I only changed the "Pyramid Test" to "Fixed Tests" to really drive home that the tests are unmutable. Also, thanks for making the code better structured.
https://www.codewars.com/kata/reviews/66c880eb984b7121720bc609/groups/66c8c43ce403b507c2fd1add
Reference solution shouldn't be put in the preloaded. Put it in the actual tests instead.
I moved it to the tests, and left the preloaded empty.
I guess I can mark this resolved as well.
The parameter should be named
stones/values/some descriptive name, notarr.done.
I wasn't sure whether it's better to leave it as plain old "arr" or make it more specific. I trust your judgement in this matter so thank you for changing it.
It doesn't seem clear from the description if the same value can appear in multiple layers.
Good remark. It can't. I'll fix it. Thanks.
I didn't know I can mark the issue as resolved, so that's why I post this comment.