7 kyu
Cyrillic letters
161 of 239FranzMartyn
Loading description...
Strings
Unicode
View
This comment has been reported as {{ abuseKindText }}.
Show
This comment has been hidden. You can view it now .
This comment can not be viewed.
- |
- Reply
- Edit
- View Solution
- Expand 1 Reply Expand {{ comments?.length }} replies
- Collapse
- Spoiler
- Remove
- Remove comment & replies
- Report
{{ fetchSolutionsError }}
-
-
Your rendered github-flavored markdown will appear here.
-
Label this discussion...
-
No Label
Keep the comment unlabeled if none of the below applies.
-
Issue
Use the issue label when reporting problems with the kata.
Be sure to explain the problem clearly and include the steps to reproduce. -
Suggestion
Use the suggestion label if you have feedback on how this kata can be improved.
-
Question
Use the question label if you have questions and/or need help solving the kata.
Don't forget to mention the language you're using, and mark as having spoiler if you include your solution.
-
No Label
- Cancel
Commenting is not allowed on this discussion
You cannot view this solution
There is no solution to show
Please sign in or sign up to leave a comment.
Good kata Товарищ! USSR гордиться тобой! "Учиться, учиться и еще раз учиться!", как завещал товарищ Ленин(Not a Jonh Lennon XD)
Considering all translations are good + this kata seems to be unique, I've given this kata 7 kyu :)
Thank you!
missing
it
block in random tests.Replaced
test.describe
withtest.it
✅That's not quite what I meant. I created a fork for your future reference.
Ohh ok, I see what you meant. Approved your fork ✅
Style remarks:
case_ = randint(1, 2)
is generally unnecessary. Just generate X cyrillic letters, Y non-cyrillic letters, and shuffle them together. This also saves you the trouble of having a reference solution.sol_495banana541
is not necessary, and a "normal" name, likerefsol
orreference_solution
or something like that should be good?Implemented your remarks ✅ Even though there is a reference solution now, I decided to keep it in for simplicity's sake
For the first kata that's actually not bad, but there are some advices regarding the testing code:
@test.describe
instead of@test.it
within fixed tests section — that may confuse some people like me;letter = chr(randint(0, chr_MAX_PARAM)) # Not including \0 just in case
— this can actually spawn \0 as one of the tests, because randint takes the random number within the parameters included;Also I'd like to propose changing the title to 'Cyrillic letters', since the Russian language does not have all the letters of Cyrillic block ;)
Fixed all of your points and thanks for having a look over my kata ✅
I think that the point 3 would apply also to
is_russian
function name and other names in the code.