6 kyu
Santa's Gone Bankrupt
Loading description...
View
This comment has been reported as {{ abuseKindText }}.
Show
This comment has been hidden. You can view it now .
This comment can not be viewed.
- |
- Reply
- Edit
- View Solution
- Expand 1 Reply Expand {{ comments?.length }} replies
- Collapse
- Spoiler
- Remove
- Remove comment & replies
- Report
{{ fetchSolutionsError }}
-
-
Your rendered github-flavored markdown will appear here.
-
Label this discussion...
-
No Label
Keep the comment unlabeled if none of the below applies.
-
Issue
Use the issue label when reporting problems with the kata.
Be sure to explain the problem clearly and include the steps to reproduce. -
Suggestion
Use the suggestion label if you have feedback on how this kata can be improved.
-
Question
Use the question label if you have questions and/or need help solving the kata.
Don't forget to mention the language you're using, and mark as having spoiler if you include your solution.
-
No Label
- Cancel
Commenting is not allowed on this discussion
You cannot view this solution
There is no solution to show
Please sign in or sign up to leave a comment.
Use
repr
or wrap the input in quotes forit
block, otherwise it can be easily misleaded as inputs being integersNot sure that this is necessarily an issue (as the variables already include the word string and example testcases have the binary strings as strings), but have added quotes around the strings in the
it
blockIn the sample tests
tester("11000", "01111", 4, 1)
:Isn't it :
To prevent bad understanding, maybe add in the description that indices are
1-based
in your sample tests.Fixed
Fancy coding challenge just for the holidays, happy ones everybody then.
The description is hard to read: see suggested description update. See if you like this update or not.
I do agree that the description is a bit hard to read, so thank you for the fork. My main concern with your fork is that it doesn't mention anything removing elements, only "optimizing the gift production", which I feel is unclear. Additionally, though this might be due to the fact that I'm used to the formats of other sites, but I feel the large amount of headers do clutter the description, and information could be more easily condensed. I've made a fork of your work, and would like to know your thoughts on it.
Thanks! (changing it in the meantime just to replace the current description)
Yeah this works too