Beta
Remove outliers
Loading description...
Statistics
Mathematics
This comment has been reported as {{ abuseKindText }}.
Show
This comment has been hidden. You can view it now .
This comment can not be viewed.
- |
- Reply
- Edit
- View Solution
- Expand 1 Reply Expand {{ comments?.length }} replies
- Collapse
- Spoiler
- Remove
- Remove comment & replies
- Report
{{ fetchSolutionsError }}
-
-
Your rendered github-flavored markdown will appear here.
-
Label this discussion...
-
No Label
Keep the comment unlabeled if none of the below applies.
-
Issue
Use the issue label when reporting problems with the kata.
Be sure to explain the problem clearly and include the steps to reproduce. -
Suggestion
Use the suggestion label if you have feedback on how this kata can be improved.
-
Question
Use the question label if you have questions and/or need help solving the kata.
Don't forget to mention the language you're using, and mark as having spoiler if you include your solution.
-
No Label
- Cancel
Commenting is not allowed on this discussion
You cannot view this solution
There is no solution to show
Please sign in or sign up to leave a comment.
In your kata's description, you have a typo in the examples section. You currently show "[1, 2, 3, 4] => Median 3.5 LQ 1.5 UQ 3.5". The Median should be "2.5", not "3.5".
Thanks for the catch! Fixed 👍
You should explain how Q1 and Q3 are calculated.
The description has a section on this:
Is there anything missing or unclear about this description? Perhaps an example will help?
Maybe I'm just bad at reading instructions, but the way I read it: find median, split into 2 halves, and then... what? I guess an example could be helpful.
Description should now be more clear
Seems a lot better. You got my satisfied vote ;-)
You can pass all random tests with the initial code. It looks like random tests aren't finished yet?
There are 2 types of random test, one to ensure that you remove all outliers, the other to ensure that the data is unchanged if there are no outliers. Since the initial code just returns the data completely unchanged, this will pass cases where non-outliers are not removed.
I'm not seeing that all random tests pass with initial code, just the ones that should. Can you confirm on your end?
(eta: I have updated the tests now as well for accuracy and clarity)
Updated random tests, let me know if you spot any more issues with those!
Assertion messages are poor: "
expected [ Array(12) ] to deeply equal [ Array(10) ]"You can fix this by importing
configfromchaiand adding this line:config.truncateThreshold = 0;Fixed - thank you so much!
Sample tests try to import "getQuartiles", which isn't defined anywhere.
Fixed - thanks so much for catching this!