7 kyu
Arrays of the Right Depth
Loading description...
Lists
Arrays
View
This comment has been reported as {{ abuseKindText }}.
Show
This comment has been hidden. You can view it now .
This comment can not be viewed.
- |
- Reply
- Edit
- View Solution
- Expand 1 Reply Expand {{ comments?.length }} replies
- Collapse
- Spoiler
- Remove
- Remove comment & replies
- Report
{{ fetchSolutionsError }}
-
-
Your rendered github-flavored markdown will appear here.
-
Label this discussion...
-
No Label
Keep the comment unlabeled if none of the below applies.
-
Issue
Use the issue label when reporting problems with the kata.
Be sure to explain the problem clearly and include the steps to reproduce. -
Suggestion
Use the suggestion label if you have feedback on how this kata can be improved.
-
Question
Use the question label if you have questions and/or need help solving the kata.
Don't forget to mention the language you're using, and mark as having spoiler if you include your solution.
-
No Label
- Cancel
Commenting is not allowed on this discussion
You cannot view this solution
There is no solution to show
Please sign in or sign up to leave a comment.
Hi,
The description is misleading. Or the tests are not built correctly, I'm not sure...
What I did is count the depths of the empty arrays only. That's not matching "the depth of all subarrays" => either the tests are insufficient, or the description is misworded.
Cheers
Ahh, I think, I got what you meant. This is indeed misleading. I have just changed my description. Could you confirm if it sounds alright now?
I actually don't see any difference... :thinking:
First things first: is that correct?
[[[]]], {2:1} -> True
I tried to fix description, I especially tried to remove term subarray from it. but probably I misunderstood... Yeah, [[[]]], {2:1} -> True is correct. The idea is that first layer of brackets is the main array which does not affect other 2 layers of brackets [[]]
ok, so:
that example should be the first one in the description and the tests
the actual specs are something like (rewroding might be needed here or there):
BTW: why this constraint
There will always be at least one array in the input.
? As long as the input is an array, it could also be empty. It's just that it will satisfy any constraint.Thank you very much for your help! I have just changed completely the description and it should ( I hope ) sound better. The constraint "There will always be at least one array in the input." was me trying to be nice to the solvers but I agree that it could be also be empty. I will try to avoid this practice in the future!
yup, LGTM :+1:
I like the kata! It provided me with some valuable practice. My only suggestion would be to change the line "Dictionary may be empty at all" to "Dictionary may be completely empty." (The expression "at all" is only used in negative statements, e.g., "The dictionary contains nothing at all.")
Thank you a lot for telling! I have fixed it and it should now appear as "Dictionary may be completely empty." Will keep this in mind and avoid using "at all" in such contexts! Thank you :)
And I am really glad you enjoyed this kata!!
Yes, I certainly did. I hope you will create more kata.
Thank you very much! Your words are a huge motivation to me and I will certainly try to create more!!!