6 kyu

A Simple Music Decoder

170 of 356chainsaw-maniac
Description
Loading description...
Algorithms
View
AllIssues4QuestionsSuggestions4Show Resolved
  • Please sign in or sign up to leave a comment.
  • maestroviktorin Avatar

    It would be nice to see this kata available in Python as well as A Simple Music Encoder, I hope someone will notice this suggestion. Thanks in advance, guys!

  • trashy_incel Avatar

    in the description, there is whitespace in the compressed examples e.g. "0-4/2, 5, 7-5" even though there are no spaces in the test cases

  • user9644768 Avatar
     
    expected [ Array(43) ] to deeply equal [ Array(45) ]
  • ejini战神 Avatar

    This comment has been hidden.

    • akar-0 Avatar

      Well, fixed tests already have '-2*2' and 1--5/2' (do you mean basic tests?)... More than fixed tests, I would say:

      • The description should state clearly that we may receive that kind of inputs (negative integers).
      • This should be seriously tested with random tests, and not only two fixed tests (my code doesn't handle negative numbers, but I could pass the kata by only adding those two exceptions).
  • ParanoidUser Avatar

    This comment has been hidden.

  • smolen Avatar

    That kata took me alot of my time building my spaghetti,damn you!

    Thanks for the kata,cheers!

  • wthit56 Avatar

    Great kata! One minor suggestion: add more notes about what can have signs. First? Last?

    • chainsaw-maniac Avatar

      Thanks wthit.

      About signs, please see comments below from cyril and dinglemouse. We more or less agreed that omitting them from the description was OK (i.e. cyrils "final boss" test). But please let us know if you disagree.

    • wthit56 Avatar

      Hrm... it just seems a bit cheap to me. It just seems unfair, like the spec wasn't complete and you added it at the last minute without telling anyone. I used to work in the development industry, and have become allergic to scope creep ;P

    • wthit56 Avatar

      In general, I take a "make it as easy as possible for the coder to understand" stance. We're testing their ability to implement the spec, not their ability to interpret it and guess at what you want...

    • chainsaw-maniac Avatar

      I understand, I am annoyed myself by incomplete specs. In this case I think the opposite point of view is that we're also testing for ability to understand a spec and not rely solely on examples, incomplete by construction. "Integers" isn't really ambiguous, it includes negative integers ; "both positive and negative integers" can be considered redundant. Anyway, I'm happy either way, but so far it 2 against 1 :-/

    • wthit56 Avatar

      Okay, fair enough. ^^

      Suggestion marked resolved by wthit56 8 years ago
  • dinglemouse Avatar

    Thanks for the heads-up about the Java version :-)

    ~

    One small suggestion : Neither the kata description nor the examples show that negative numbers are possible.

    Maybe you are leaving that as a deliberate "surprise" for the harder tests, or maybe it should get a mention in the description.

    • chainsaw-maniac Avatar

      Yes, it's a deliberate omission. If this is considered bad practice, I'll fix it (I'm relatively new here). Let me know!

    • cyril-lemaire Avatar

      I like when katas have a "true last boss" that pops when you confidently hit Submit as long as it's only a logical feature you did not think of and not a rules inconsistency.

      Nice kata btw :D

    • chainsaw-maniac Avatar

      Thanks! I love the "final boss" analogy ; I'm even tempted to rename the tests :-)

    • dinglemouse Avatar

      OK. Just checking.

      BTW, I also think it is a good learning experience to be tripped up by something I forgot to consider... :-)

      Suggestion marked resolved by dinglemouse 8 years ago
  • smile67 Avatar

    This comment has been hidden.