Made some rewrites to the JS translation (ie. added fixed tests, cleaned up random tests, etc.), so it's now in parity with the Elixir translation. Also, the expected and actual results (for the random tests) will only print to console in the case of a test failure.
You should add other sample tests (each time with the number of iteration equal to 2 or 3):
one with a non squared array
3 other with the triangle, but rotated ([[0,1],[1,1]], [[1,1],[0,1]] and [[1,1],[1,0]])
And it's rather useless to print expected/actual to the console if the test is ok (and even when it fails: for more than 3 iterations, the display isn't readable anyway).
cheers
(posting as an issue, since the author is inactive => needs access available to PUs)
I have corrected all the spelling errors I could find, I believe I caught all the ones you mentioned.As for 8, I think just removing that bit makes it less unclear (why am I using a double negative? IDK...) and 10, I did as you suggested and reformatted the bottom a little to compensate.
This is the most fun kata I've solved in a while. Fun problem, clear description and excellent tests. I'm definitely gonna try some more approaches to solving it.
The only thing I can comment on is the description, which has some minor typos. Don't take this as criticism, I only did it because I like the kata and want it to be even better. :)
Layout: Add a line break between the picture and the first line of text. You could also put the picture before the text, if you think that looks better.
Typo: (several places) "Sirpinski" should be "Sierpinski"
Typo: (first heading) "Each subsequent iterations" should be "Each subsequent iteration"
Typo: (first heading) "Normally an IFS's sub-camvases" should be "Normally an IFS's sub-canvases"
Typo: (first heading) "It's also prabably" should be "It's also probably"
Typo: (first heading) "but IFS' work with" should be "but IFSes work with" (or "IFSs", but IMO the "es"-suffix works better)
Typo: (second heading) "1 or a 0 coresponding to" should be "1 or a 0 corresponding to"
Layout: (second heading) "A pixel is either a "#" and a space # for on or 2 spaces for off." The markdown eats up the spaces here. One way to get around it is to do something like #_ and __ and add a line which explains that _ stands for whitespace.
Typo: (third heading) "into a square it wold be" should be "into a square it would be"
Suggestion: Remove the Sierpinski carpet example and replace it with the first three iterations of the Sierpinski triangle. I feel that having one strong example is better than having two half-examples.
It's cool to see people still are playing with this;
I haven't looked at CodeWars in a while, sorry about that, but looks like you got it aproved
Cheers!
approved
OP has left. Any power user want to approve this?
Made some rewrites to the JS translation (ie. added fixed tests, cleaned up random tests, etc.), so it's now in parity with the Elixir translation. Also, the
expectedandactualresults (for the random tests) will only print to console in the case of a test failure.Haskell translation
approved
Elixir translation awaiting approval.
This comment is hidden because it contains spoiler information about the solution
Hi,
You should add other sample tests (each time with the number of iteration equal to 2 or 3):
[[0,1],[1,1]],[[1,1],[0,1]]and[[1,1],[1,0]])And it's rather useless to print expected/actual to the console if the test is ok (and even when it fails: for more than 3 iterations, the display isn't readable anyway).
cheers
(posting as an issue, since the author is inactive => needs access available to PUs)
I see, your solution is bypassing the point, so I added a 30x30 character restriction
Would you like to set some additional restrictions? Or it's going to be 7 kyu, "6.5" kyu maximum.
I really appreciate your comment!
I have corrected all the spelling errors I could find, I believe I caught all the ones you mentioned.As for 8, I think just removing that bit makes it less unclear (why am I using a double negative? IDK...) and 10, I did as you suggested and reformatted the bottom a little to compensate.
This is the most fun kata I've solved in a while. Fun problem, clear description and excellent tests. I'm definitely gonna try some more approaches to solving it.
The only thing I can comment on is the description, which has some minor typos. Don't take this as criticism, I only did it because I like the kata and want it to be even better. :)
Layout: Add a line break between the picture and the first line of text. You could also put the picture before the text, if you think that looks better.
Typo: (several places) "Sirpinski" should be "Sierpinski"
Typo: (first heading) "Each subsequent iterations" should be "Each subsequent iteration"
Typo: (first heading) "Normally an IFS's sub-camvases" should be "Normally an IFS's sub-canvases"
Typo: (first heading) "It's also prabably" should be "It's also probably"
Typo: (first heading) "but IFS' work with" should be "but IFSes work with" (or "IFSs", but IMO the "es"-suffix works better)
Typo: (second heading) "1 or a 0 coresponding to" should be "1 or a 0 corresponding to"
Layout: (second heading) "A pixel is either a "#" and a space
#for on or 2 spacesfor off." The markdown eats up the spaces here. One way to get around it is to do something like#_and__and add a line which explains that_stands for whitespace.Typo: (third heading) "into a square it wold be" should be "into a square it would be"
Suggestion: Remove the Sierpinski carpet example and replace it with the first three iterations of the Sierpinski triangle. I feel that having one strong example is better than having two half-examples.
Again, thanks for the great kata!
lol, I just replaced 3 with 2 in my code, I didn't check it. I'm just going to trash this Kata.
Loading more items...