• ###### Mednoobcommented on ""How Many is Divisible by x" JavaScript Translation"
• Solution failed to handle `x = "a and b"` where `GCD(a,b) != 1` (for example `m = 20, x = "2 and 4"`, it returned `2 {8, 16}` instead of `5 {4,8,12,16,20}`). The number should be divided by `LCM(a,b)` instead of `a*b`.
• `LCM(a,b)` should be `(a*b)/GCD(a,b)` instead of iterating to nearest multiple of `a` and `b`, imo.
• ###### demeshko_egorcommented on "Grasshopper - Create the rooms" kata

yeah, good Kata for data struchers, but description. also had to watch test> to understand.

• ###### k.dmitriy.a@gmail.comcommented on "Check Even Number" kumite

You used my previous solution ;)

• ###### kryzalcommented on "Check Even Number" kumite

#you can use this code for less confusion
is_even = lambda a: a%2==0

• ###### puehutalocommented on "Check Even Number" kumite

0 is False and 1 is True

• ###### vandaminatorcommented on "Check Even Number" kumite

do you want it to return 0 when not even, and 1 when even?

• ###### m-oxucommented on "Dan's Kumite" kumite

Hello,

I don't know if it´s intended, but a function wrote in one single line is extremely difficult to read and understand what it is doing, mainly because of all the if-elses.

• ###### Shaba-Rexcommented on "Sort string" kumite

Damn i always forget to use the return of the sorted method, thanks for the tip :)

• ###### Insistedcommented on "Sort string" kumite

A tip: you could just replace `list` with `sorted` to make it shorter
`sort = lambda x: ''.join(sorted(filter(str.isalpha, x)) + sorted(filter(str.isdigit, x)))`

And it's also sorting less element

• ###### Mavengercommented on "Check Even Number (Without Spaces or Numbers)" kumite

*chef's kiss* now with 100% less `ord()`!

• ###### Insistedcommented on ""USD => CNY" Java Translation"

My bad, gonna fix it now. Thanks!

Edit: Done! And added 2 more test case (0 and 100 USD)

• ###### hobovskycommented on ""USD => CNY" Java Translation"

Solution setup uses input of type `double`, and "Solution" snippet uses `int`.
Input should be (or even must be) `int`, not `double`.

Cool quotes

• ###### Insistedcommented on "Strip Comments" kata

Any whitespace at the end of the line should also be stripped out.

Any form of whitespace should only be removed if it is trailing behind the sentence

• ###### Insistedcommented on "Stop gninnipS My sdroW!" java solution

This solution teaches me how to use a made function (Not the lambda one) on an Arrays stream's map