manageEventsStrings("open toggle foo baz", "close bar baz", "toggle");
manageEventsStrings("open foo baz", "close toggle bar baz", "toggle");
I'd expect that you shouldn't have toggle in either doActions or undoActions, since it's found in toggleActions, so the result from both of those should be ["open.codeWars foo.codeWars", "close.codeWars bar.codeWars", "toggle.codeWars baz.codeWars"].
That isn't really clear from the description, though: any verb that is found in both doActions and undoActions should be added to toggleActions, and then any verb found in toggleActions should be skipped in both doActions and undoActions if it occurs in either of those. You only covered the case where it's found in both doActions and undoActions, not when it occurred in only one of them but also in toggleActions.
Recent changes in the codewars platform broke the original version of this kata. I have updated the example test fixture so that the tools are available. In any case, submitting your solution always worked; it was only the "run tests" that was broken.
ReferenceError: codewars is not defined<:LF:> <:LF:>
throw ex; ^ ReferenceError: codewars is not defined at [eval]:10:144 at [eval]:20:3 at at [eval]:3:6 at Object. ([eval]-wrapper:6:22) at at evalScript (node.js:536:25) at startup (node.js:80:7) at node.js:906:3
I'd suggest adding non-letter characters (i.e. numbers, punctuation marks rtc.) and mention about it in description. This should make kata a little bit more universal :)
As mentioned below, the specs are incomplete: what if
togglecontains strings that is contained indo/undotoo?"Performance test" is not actually testing for performance: input size is too small.
namespaceshould be passed in as an argument, not as a global variable.Needs actual random tests.
What should happen if you have the following?
I'd expect that you shouldn't have
togglein eitherdoActionsorundoActions, since it's found intoggleActions, so the result from both of those should be["open.codeWars foo.codeWars", "close.codeWars bar.codeWars", "toggle.codeWars baz.codeWars"].That isn't really clear from the description, though: any verb that is found in both
doActionsandundoActionsshould be added totoggleActions, and then any verb found intoggleActionsshould be skipped in bothdoActionsandundoActionsif it occurs in either of those. You only covered the case where it's found in bothdoActionsandundoActions, not when it occurred in only one of them but also intoggleActions.Still wondering how to get kata out of beta process...
Recent changes in the codewars platform broke the original version of this kata. I have updated the example test fixture so that the tools are available. In any case, submitting your solution always worked; it was only the "run tests" that was broken.
Intresting kata, but unfortunatelly i get:
when i try to run tests
It's still showing that this kata has one minor issue in the profile. Can't figure out how can I "close" it. Could you please help me with advice?
I'd suggest adding non-letter characters (i.e. numbers, punctuation marks rtc.) and mention about it in description. This should make kata a little bit more universal :)
Sorry! Thats my first try. I thought this should come from "preloaded" part of kata for both final and example tests.
Updated kata. Thank you.
no namespace defined for tests