Ad
  • Custom User Avatar

    This comment is hidden because it contains spoiler information about the solution

  • Custom User Avatar

    Some tests seem artificial and are not specified anywhere:

    • Test 0 team league <- 0 teams, no league in my book
    • Test 1 team league <- 1 team, same as above
    • Test all lose league <- If there is a loser, there should be a winner, where is it?
    • Test strange number of games <- In a normal league unless there is some kind of playoff, all teams play the same amount of games. With only two teams the amount should be equal no matter what.
  • Custom User Avatar

    Sorry, I cannot find anything about an empty league (winner({})) in the description.
    Maybe your update got lost?

  • Custom User Avatar

    The description doesn't mention that moving to page through navigate after calling back a few times modifies the URL history.

  • Custom User Avatar

    Depends. The way I see it, solving kata is the primary goal of this website, not creating kata. Creating kata is not a right, it's not necessary to do so to use CW ( sure - someone will have to create kata. but it doesn't have to be you ), and the bar for creating kata should be [ much ] higher than for solving them. Everybody is going to solve kata, not everybody is ( or should be! ) going to create them.

    The breakdown in the system used to be the complete lack of documentation; these days however, to me, it seems to be people not reading it ( because there is documentation, now ). I don't think the problem is people reading it but then not complying with it.

    I see a lot more of "I don't know how to create random tests" than of "I don't think random tests are necessary for this kata" ( let alone "I honestly tried, but random tests are quite impossible for this kata" ).

    As long as Qualified.io lets us moderate ourselves and refuses to [ spare the resources to ] do it officially, we will sometimes have a bad day and completely destroy a new kata, and its creator, that frankly deserve it but for basic human decency. This is the Internet after all. It may not be desirable, but it happens lots of places exactly the same way. People get Eternal September Syndrome all over the place. ( Note: I, too, am from that September, though reasonably early in it - less than a year actually. I just know my classics. )

  • Default User Avatar

    Yeah, I agree that might happen, but that is a sign of a broken system.

  • Default User Avatar

    There are sample tests, there are a lot of expanded tests but none randomized.

    Please split up issues, as otherwise when people try to address them they have to check the comments, code, etc. to find out which ones if any were addressed.

  • Default User Avatar

    Adjusted the description, reraise (being specific) if anything is still missed.

  • Custom User Avatar

    Problem is you really have to get mostly everything mostly right from the get-go, or people might not vote "Fully satisfied" and your kata will be retired.

    If you keep churning out kata without random tests, they'll all get retired.

    The grammar and spelling thing was a suggestion, not an issue; it was phrased as such; and I stand by it as a suggestion. See Kata Best Practices - Use Proper Grammar, Punctuation and Spelling.

  • Default User Avatar

    Description updated.

  • Default User Avatar

    Karishay,

    I added a very basic random test generator, have a look at it, I would suggest a number of things you could improve :

    • note I just ripped out a section of your solution to calculate the points (to ensure there are no cases where teams have the same points), this is obviously a big code duplication you could remove

    • in fact there is probably a smarter way to generate the scores to prevent that while loop which just generates cases until it makes a set with no same points

    • it looks like you maybe wanted to have more than two entries in the scoring, that could be added to the generator as well

    • in fact the entire generator itself could be cleaned up as there is duplication in multiple areas, in fact I think you could use destructing to do that, but I am not that familar with destructuring in JS (or JS really)

    If you have any questions just let me know.

  • Default User Avatar

    Johan,

    When learning a task, the focus has to be on the priority of the task, even for a native speaker, they might not have a strong english background. In India, I saw lots of people who could speak English well, but written it is very poor.

    It is easy to hammer a kata with every possible criticism, I just don't think it is at all productive, especially for a beginner, the focus is all on the wrong areas.

  • Custom User Avatar

    And it might not help to have a native speaker correct his "its" and "it's" - that's being done wrong by [ some ] native speakers. But it might take out the more obvious typoos.

    I have trouble believing there are people on here who truly are the only person they know that speak English. You're a programmer, and there's thousands of people on here that do. Hell, I might be willing to help when asked. ( Not that I'm a native speaker .. )

    Spurious apostrophes can rather easily be avoided by not using them - just spell out "~ is", and when that looks wrong, lose the "is" - that's when you should not be using an apostrophe either. I fail to see how that's hard - it just means you don't care. You don't have to, I can't make you, but you run the risk of being told it's wrong.

  • Custom User Avatar

    I could, but I won't.

  • Default User Avatar

    can you elaborate a bit more?

  • Loading more items...