I agree. The random tests in the Ruby version of this Kata, generate several different invalid times as input but don't expect "false" to be returned. Examples include: 23:24AM, 20:49AM, 22:08AM, ...
Fixed
fixed. You should print Error 404 instead of invalid value - that was a typo.
This comment is hidden because it contains spoiler information about the solution
The instructions say "If the given input is not an integer, return "Error 404"." But the tests look for "Invalid Value"
It seems that some of the random tests provide invalid times but do not expect false.
Testing for convert_time(12, 21:44AM) It should work for random inputs too - Expected: "09:44AM", instead got: false
Testing for convert_time(12, 21:44AM)
It should work for random inputs too - Expected: "09:44AM", instead got: false
Loading collection data...
I agree. The random tests in the Ruby version of this Kata, generate several different invalid times as input but don't expect "false" to be returned. Examples include: 23:24AM, 20:49AM, 22:08AM, ...
Fixed
fixed.
You should print Error 404 instead of invalid value - that was a typo.
This comment is hidden because it contains spoiler information about the solution
This comment is hidden because it contains spoiler information about the solution
This comment is hidden because it contains spoiler information about the solution
The instructions say "If the given input is not an integer, return "Error 404"."
But the tests look for "Invalid Value"
It seems that some of the random tests provide invalid times but do not expect false.
Testing for convert_time(12, 21:44AM)It should work for random inputs too - Expected: "09:44AM", instead got: false