Loading collection data...
Collections are a way for you to organize kata so that you can create your own training routines. Every collection you create is public and automatically sharable with other warriors. After you have added a few kata to a collection you and others can train on the kata contained within the collection.
Get started now by creating a new collection.
hh
I forked with correction you missed.
Those are perfectly fine. You just made one thing better, and added another type in the other change.
OK, I did. But would you mind answering my second question for next time? Are pure grammatical typos not allowed in a fork?
just fork again, but replace "plus" by "and"
Besides the typo, the main thing to me was that it was confusing at the point where it says "row and their skill level"; to me this could mean that both the row's sum and their skill level need to be equal or greater.
I also never usually post improvements, but in general, do they have to significantly improve the description in order to be approved? A little improvement is not valid?
Except for the typo fix, not an improvement at all.
Because there's no need to reinvent the wheel.
I am also lost. What is a decimal representation?
While I agree it can be improved as you said, I consider something as a kata issue if the user can't fix it changing his/her code. In this case, the problem comes from the user returning a different datatype from the expected one, and it can be fixed by the user, returning the expected one.
I would still consider crashing tests a kata issue. If tests want to use the returned value in a non-trivial way, it should be sanitised and not cause a crash.
Well, you're returning a list instead of a number, that's your code's problem, not a kata issue.
I get a TypeError no matter what I do, whether I am testing or attempting the solution.
The problem seems to be the "testing" function defined. I get:
The
listtype just changes to 'None' if I just return nothing. Can anybody help?Reviewed, Forked & Approved. (Honor points goes to you)
Loading more items...