Loading collection data...
Collections are a way for you to organize kata so that you can create your own training routines. Every collection you create is public and automatically sharable with other warriors. After you have added a few kata to a collection you and others can train on the kata contained within the collection.
Get started now by creating a new collection.
Every test assertion is calling user function twice. This is a bad practice. Please store the result when you finish calling user function, and reuse that value.
Sample tests are not updated.
const
is not changed in initial code either.Looks like they've been removed
Why is initial code
?
https://www.codewars.com/kata/reviews/663b7ea9feb77100010c6df6/groups/663b88867c8142000150bc4d
Tag
binary search
is not needed anymore as reference solution has since changed to a different algorithm.Array size is at most
50
. Why is there aoptimization
tag?Reference solution fails when the tallest building has more than one occurrence:
The highest building is
991
, so992
will topple every building. This is a trivial upper bound.Ok
"not yet complete": what about
Cancelled
? Are there more possible project statuses, or are they just free text?This sentence is contradictory to itself, and the example output given (where all projects have status
Incomplete
).Random tests are not random at all:
deepams
are tested in sequence, and the pattern for each group of tests is always the same.The kata design is straight out un-Pythonic: if something that should format and return a dynamic string is required, it should be a method. Making it a property (which doesn't need to be called) is already a stretch. Making it a class variable is straight out insane.
As a kata these kinds of nonsensical design is unacceptable.
It doesn't even work as what you intend at all:
DEEPAMS
is defined as a class variable instead of a instance variable, and when a instance is created its value is then copied to the instance.There are only 6 fixed tests (which means no random tests).
Random test inputs contain duplicate elements. Pretty sure a shuffle can't duplicate cards.
.
Loading more items...