Why does the graph even have vertices if we don't care about these? It's not tested that the department vertices are part of those of the graph. This seems really weird, and even incorrect to me.
You can make the isPrime method much more efficient by only checking against other prime numbers under p. Since you are building up the prime cache starting from 2 and working your way up there is no risk of missing primes.
I missed that the upper bound was Math.sqrt in my solution.
The kata is suspectible to modifying input objects, e.g fightBetweenSameGladiatorsShouldReturnFirstParameterAsWinner will fail at second test if input is modified (which seems to be expected).
The fight method is a duplicate - here is a similar kata with a slightly different algorithm, but I think I've solved 1 or 2 more katas which were closer to what we're supposed to do here (edit: another similar kata's been mentioned in this comment). As for everything else (implement a constructor and other pointless boilerplate) - that's been done in numerous katas in some form too. As a result, I'd say that this one lacks novelty overall.
hi ^_^ you used .sort() - customers+1 times. What about realy big supermarket with 10^8 of customres and 10^2 tills? ;))) This kata may solved w/o sort anyway
Why does the graph even have vertices if we don't care about these? It's not tested that the department vertices are part of those of the graph. This seems really weird, and even incorrect to me.
I wanted to log the same thing. I cannot find this crucial info in the description. I'm sure it's hidden in plain sight.
"Efficiency is not a key point of this part of the series" - but I have time out - 16s and so many random tests(
I am not complain!)
Strange, 6 points for so easy task, as I see
You can make the isPrime method much more efficient by only checking against other prime numbers under p. Since you are building up the prime cache starting from 2 and working your way up there is no risk of missing primes.
I missed that the upper bound was Math.sqrt in my solution.
Thanks for explanation!
This even can be improved by implementing List or Collection interface
this is a very cool solution and still very readable in my opinion, didn't think of using it
you can print the input without any of your code running to see the random tests
Could someone please share a random test? My solution times out, although I seemingly dealt with loops and nonexistent paths
shouldCreateGladiatorWithDefaultInitiative I am getting this test case failed I am not sure what mistake am doing could anybody give some hint ?
The kata is suspectible to modifying input objects, e.g
fightBetweenSameGladiatorsShouldReturnFirstParameterAsWinnerwill fail at second test if input is modified (which seems to be expected).The
fightmethod is a duplicate - here is a similar kata with a slightly different algorithm, but I think I've solved 1 or 2 more katas which were closer to what we're supposed to do here (edit: another similar kata's been mentioned in this comment). As for everything else (implement a constructor and other pointless boilerplate) - that's been done in numerous katas in some form too. As a result, I'd say that this one lacks novelty overall.hi ^_^ you used .sort() - customers+1 times. What about realy big supermarket with 10^8 of customres and 10^2 tills? ;))) This kata may solved w/o sort anyway
Amazing kata! I enjoyed coding this one the most so far
Loading more items...