Ad
  • Default User Avatar

    python initial code has a tab character in it

    (sample tests and tests too)

  • Custom User Avatar

    JS

    Tests throw seconds. Didn't see about seconds in task, but lose time with needless calculatings seconds.

    Task closed due setting seconds to 0 into code.

  • Custom User Avatar
  • Default User Avatar

    it's underspecified whether hours is between [0, 12[, [1, 12], or [0, 24[ . There were originally fixed tests for 12:00, 00:00 and 12:30. If both 00:00 and 12:00 are valid then it cannot be a 12-hour clock as specified in the description, and tests for hours between [12, 23] should be added.
    Conversely, if tests for 00:xx are deleted, then it can be a 12-hour clock with hands in [1, 12].

  • Default User Avatar

    no random tests in Ruby

  • Custom User Avatar

    Coffeescript translation kumited. Have fun! ;-)

  • Custom User Avatar

    This comment is hidden because it contains spoiler information about the solution

  • Default User Avatar

    I keep getting one single error in final tests when comparing Ace of Hearts and 10 of Hearts. I've tried making my own tests with same cards and they pass as they should:
    Test.expect(new Card(Card.HEARTS, 1) > new Card(Card.HEARTS, 10)); => Test Passed;
    Test.expect(new Card(Card.HEARTS, 1) < new Card(Card.HEARTS, 10)); => Value is not what was expected;
    Test.expect(new Card(Card.HEARTS, 1) == new Card(Card.HEARTS, 10)); => Value is not what was expected;
    All the other comparisons in final test pass as well. Is there something wrong with final tests?

  • Custom User Avatar

    I was stuck on a few tests for a long time due to assumptions made from reading the description. A lot of frustration could have been avoided with the following changes:

    "Upon initialization, a deck is filled with 52 cards (13 from each of 4 suits)."
    I read this as suggesting that a new Deck would be filled/passed the 52 cards, not that we should produce that ourselves. In retrospect I realize it makes perfect sense that the deck should clearly have that ability itself. However, the wording really misled me into thinking it wasn't the deck's responsibility.
    Perhaps "a deck is filled with" should read "your deck should fill itself with".

    "Cards must be Comparable to other cards. Compare the ranks of the cards only."
    This could definitely be clearer as to its intention. I gave up on this kata as my logs showed perfectly equal cards, and the fail messages simply said they weren't equal. I couldn't sniff out how they were being compared either. The error messages could be refined or at least the description.

    Perhaps "Cards must be comparable to other cards." (capitalization of Comparable is misleading) "The value of a Card object should return its rank for the purpose of comparing two Cards."

  • Custom User Avatar

    This comment is hidden because it contains spoiler information about the solution

  • Default User Avatar

    This comment is hidden because it contains spoiler information about the solution