Ad
  • Custom User Avatar

    Why return type is Object? Well, there's only one reason: You're making us returning error strings while correct output is a double.

    That's a very bad design. Please learn how to catch exceptions properly during testing and throw exceptions for input validation instead. Don't teach others bad practices ;-)

    Also, the input validation: it's not just besides the point of the task, it's another bad design: in an actually good design you'd instead have different methods for each shape type, along with the appropriate arguments. Again, learn to make good designs before writing a kata: everyone will be learning from you. Please be a responsible role model ;-)

  • Custom User Avatar

    why the rounding? -> use proper method to check for floats: assertEquals(msg,exp,actual,precision)

  • Custom User Avatar

    Needs Random Tests.

  • Custom User Avatar

    circlePipe

    What is a pipe? There are nothing related to pipe or wall in the given wiki page.