I was wondering what was expected in the case of a word only composed of consonants. Should it just stay the same ? Or should it stay the same and have a ay appended (which seems to be what's currently expected) ? I think it's worth mentionning in the description.
There are many problems with the current JavaScript version. I believe it would be better to fix those issues before making any translations.
For instance, there are no random tests in the JS version.
Also, your translation tests : and ; as punctuation, while the original doesn't. I'm not saying that yours shouldn't, but it would be better to add it to the original one before approving this translation.
On the translation itself, please don't create a test.it block for every single test, this is ugly, messy and slow. Group many of them into a single one and only display the input if the user fails the test.
Approved.
Approved.
Lua translation with merge conflicts resolved (author is inactive), can be approved.
Muito bom!
Added after the translation rework was approved.
Done.
Lua translation !
I was wondering what was expected in the case of a word only composed of consonants. Should it just stay the same ? Or should it stay the same and have a
ay
appended (which seems to be what's currently expected) ? I think it's worth mentionning in the description.approved, if you want to make some more changes, suggest a new fork
approved
JS translation rework kumited (author is inactive)
Nim translation
You can fork the JS version
Well I can't modfy the JS version without having my Python translation approved.
As for the other suggestion, that is what some people suggested me to do in #reviewing (Codewars Discord).
There are many problems with the current JavaScript version. I believe it would be better to fix those issues before making any translations.
For instance, there are no random tests in the JS version.
Also, your translation tests
:
and;
as punctuation, while the original doesn't. I'm not saying that yours shouldn't, but it would be better to add it to the original one before approving this translation.On the translation itself, please don't create a
test.it
block for every single test, this is ugly, messy and slow. Group many of them into a single one and only display the input if the user fails the test.Loading more items...