Ad
  • Custom User Avatar

    This comment is hidden because it contains spoiler information about the solution

  • Custom User Avatar

    This comment is hidden because it contains spoiler information about the solution

  • Custom User Avatar

    Sample test still uses old classifications naming.

    To match the description, 'N' should be 'C1', 'M' should be 'D1'.

  • Custom User Avatar

    Tests in Python could use some improvements. They are structured quite poorly, no good distinction into test groups, fixed tests, random tests, etc.

  • Custom User Avatar

    It is not specified what should happen if the same character is guessed again.

  • Custom User Avatar

    Initial code is invalid: it should be self.secret instead of Hangman.secret, etc. They should not be class variables.

  • Custom User Avatar

    This comment is hidden because it contains spoiler information about the solution

  • Custom User Avatar

    I am curious, are other solutions passing 100% of the time? I got mine to pass on average 98% of the tests (which was close enough to pass all after submitting a couple times), but that certainly wont survive any updates to the kata. Based on the nature of the kata I find it very difficult to imagine a solution that is guaranteed to pass 100% of the time.

    Edit: An idea to potentially handle some of the randomness:

    • State in the description an acceptable "False positive" and "False negative" percentage value
    • Run a batch of a couple hundred (?) tests, randomly choosing between the languages. (To avoid someone writing different functions for each language, and iterating through them)
    • Keep track of which tests fail (language and expected outcome)
    • If the solution passes with high enough accuracy (for both negative and positive cases) then the solution is accepted, otherwise the results of failed tests are reported back

    Of course, just an idea and perhaps your solution can already pass 100%. If you do want highly reliable solutions though I would suggest increasing the number of tests to prevent solutions like mine and computationlan's from passing.

  • Default User Avatar

    This solution failed at a random test with

    old: -6/9+-3=1/8/7/619/168
    new: -6+9+-3=1/8/7/619/168
    

    If precise calculations are required, there should be corresponding fixed tests.

  • Custom User Avatar

    This comment is hidden because it contains spoiler information about the solution

  • Custom User Avatar

    imo, you shouldn't do 2 separated tests about the output. Just assert the whole tuple once and for all: ((dx,dy), period).
    that makes even clearer what the output is, and that decreases the mount of noise.

  • Custom User Avatar

    Duplicate.

  • Custom User Avatar

    The reference solution is kind of interesting, but impossible to recap, if you don't know the specific library. I think, it should be mentioned in the description...

  • Custom User Avatar

    This kata is very similar to:

    https://www.codewars.com/kata/56832fb41676465e82000030

    I'm not fond of the way the class is set up for that one. The board, sequence of misses, and number of strikes should be read-only properties, and the guess function simply return true on successful discovery.

    This one is concise enough that it could be rewritten as a coroutine. Thoughts or suggestions?

  • Custom User Avatar

    Duplicate.

  • Loading more items...