• ###### akar-0created an issue for "Is it a group? (Group theory, Abstract algebra)" kata

This comment is hidden because it contains spoiler information about the solution

• ###### Little Turtlecommented on "Is it a group? (Group theory, Abstract algebra)" kata

A useful fact:
It is sufficient to check if there exist a left neutral element "e" (ie. e * g == g for all g) and each element "g" has a left inverse (ie. there is "h" such that h * g == e).
Then, under associativity and using a few tricky comparisons, we can prove that any left inverse is also a right inverse, "e" is (two-sided) neutral element, from which the uniqeness of "e" and all inverses follows.

• ###### akar-0commented on "Is it a group? (Group theory, Abstract algebra)" kata

I really enjoyed this one. It'd be nice to have similar other ones for different algebraic entities (I've never seen before). Well maybe it would be nice to make them myself if they don't exist....

• ###### bdupaucreated a suggestion for "Is it a group? (Group theory, Abstract algebra)" kata

This comment is hidden because it contains spoiler information about the solution

• ###### bdupaucreated a suggestion for "Is it a group? (Group theory, Abstract algebra)" kata

It would be nice if you give information about the set and the binary operation used for a test, so that the user can debug more easily.

• ###### bdupaucommented on "Is it a group? (Group theory, Abstract algebra)" kata

You could still introduce the class in a later stage of the series

• ###### ewanmurrcommented on "Is it a group? (Group theory, Abstract algebra)" kata

Hi, I was thinking I might make it into a series of kata where you add more functions one at a time if this one went down well. I saw that in a Morse code kata and liked the idea. There are other interesting properties of groups that could be interesting to implement like finding subgroups or proving two groups are isomorphic.

• ###### Voilecreated an issue for "Is it a group? (Group theory, Abstract algebra)" kata

Shouldn't `group_set` be a `set` rather than a `list`? Otherwise there can be duplicate elements.

• ###### Voilecreated an issue for "Is it a group? (Group theory, Abstract algebra)" kata

Is it really needed to make a class just to check one thing? A class that serves no purpose but to call a single function using the constructor parameters as its parameters is meaningless. You might as well just turn it into a function `is_group(group_set, binary_operation)`.

(Marking this an issue since inevitably every other language translation will pick this up and it'll be very messy)

• ###### ewanmurrresolved an issue on "Is it a group? (Group theory, Abstract algebra)" kata

No idea how that happened

• ###### Unnamedcreated an issue for "Is it a group? (Group theory, Abstract algebra)" kata

There's an accidental JS version now...

• ###### ewanmurrresolved an issue on "Is it a group? (Group theory, Abstract algebra)" kata

Good catch! I forgot to change my original code rather than just the template, updated Thanks!

• ###### ewanmurrresolved an issue on "Is it a group? (Group theory, Abstract algebra)" kata

I've come up with three more tests that I think catch, associtivity, lack of identity and lack of an inverse while retaining the other three conditions. Thanks for the advice.

• ###### mingmingrrcommented on "Is it a group? (Group theory, Abstract algebra)" kata

Python sample tests are still using `isGroup` instead of `is_group`

• ###### ewanmurrresolved an issue on "Is it a group? (Group theory, Abstract algebra)" kata

Thank you! I don't know how I missed that, I didn't realise that when you press validate soloutions it doesn't check the examples.
I've fixed it.