Just because you changed the title to include the word Format doesn't mean anything is clear. You should update the description to explain what you're looking for.
I agree with your suggestion to add a test case for k = 0.
@raulbc777
Since 0 is not a positive integer and is not a valid value of k for the purpose of this kata anyway, < should be revised to ≤:
"If the second entry is not a positive integer (k < 0),..." <- change to "k ≤ 0"
Done in this fork
This is actually an issue :-)
Randoms test cases added.
Reraised above with more detail
seems fixed
Off-by-one errors have claimed millions of lives. 😅
Just because you changed the title to include the word Format doesn't mean anything is clear. You should update the description to explain what you're looking for.
Ok, your suggestions and observations always welcome. I'll be checking them one by one.
I agree with your suggestion to add a test case for k = 0.
@raulbc777
Since 0 is not a positive integer and is not a valid value of k for the purpose of this kata anyway, < should be revised to ≤:
"If the second entry is not a positive integer (k < 0),..." <- change to "k ≤ 0"
This comment is hidden because it contains spoiler information about the solution
RRRDRULDIndeed I falled into the same trap. Time inputs are allowed which do not make any sense like: 26:87
I suggest to add a test case, so that it can be recognized from the beginning that this one leads to a "True" result.
I guess that's one of the "bugs" you are expected to fix
If it hasn't been fixed after a year, it ain't going to be fixed.
Closing.
Loading more items...