• You can call me foolish. but what I am supposed to do here exactly? I could not understand this kata.
    Can anyone help me?

  • This comment is hidden because it contains spoiler information about the solution

  • he might need to solve some more katas and look at random tests

    Ye, that's true. I was talking in general, not specifically about that translation, because as you have spotted, that one is a bit peculiar :D

  • Well, if those languages existing are already faulty, what's wrong with adding a fully working translation (that could provide a skeleton for random tests)?

    Nothing, I corrected myself on this in the second comment. Although looking at his translation he might need to solve some more katas and look at random tests in ones where there's no issue raised about them, and also credit the user whose solution he copies as reference.

  • Even so, I'm not sure I agree :P Well, if those languages existing are already faulty, what's wrong with adding a fully working translation (that could provide a skeleton for random tests)? Or maybe there's something specific to this kata that I'm missing?

  • Or unless he's willing to fix those languages after having his translation with random tests added (as I would shoot myself in the foot with some other kata x))

  • You misunderstood this sentence, it means there's no point in approving translation until other languages have their random tests added, I tend to use mental shortcuts, so my sentences end up jumbled.

  • There's no point in random tests in your translation if other languages won't have them added.

    Wrong. In that case, they would never be added, unless the author would add them to all translations on their own (unlikely). While it's true that it results in slight difficulty gap between languages, but once they're added, other translators can be notified and ideally add updated translations. At that point the ones without random tests should be considered faulty and not count, but we're not there yet :P

  • The only thing that's random about the tests you added is assertion message, random tests mean random ranges, not even mentioning two loops counting into millions which should be one. There's no point in random tests in your translation if other languages won't have them added. On a side note is TS translation anyhow useful if it differs from JS by like 2 type annotations.

  • Oh, I accidentally marked the suggestion as resolved, the translation has NOT been reviewed yet!

  • Btw: Can you approve typescript translations?

  • I have added random tests now :)

  • Oh, there's no random tests. Will add that. Thanks!

  • Have you seen the issue below? You solved the kata in JS so you should see this:

    There are probably even more, these are most recent. Now so any translation would make sense the both currently available languages need to have their tests revamped and then any translation needs to follow the same way.

  • TypeScript translation :)

    Please review thanks!

  • Loading more items...