I'd suggest to add corner cases to the tests as well. I think some solutions would get an indexOutOfBoundsException if the input string would be "the-stealth_warrior-".
The Python tests seem to require the User class to have a method called inc_progress, yet the user's progress is never directly updated. It is updated based on the rank of an activity the user completes. Thus the name inc_progress is very misleading and innapropriate. There should instead be a method called complete_activity that accepts the rank of the activity completed and internally calculates the user's progress. I find this "error" very unprofessional for someone who is at a level where they are writing katas.
No random tests in Java
This comment is hidden because it contains spoiler information about the solution
I'd suggest to add corner cases to the tests as well. I think some solutions would get an indexOutOfBoundsException if the input string would be "the-stealth_warrior-".
BF translation: https://www.codewars.com/kumite/6818f20654568865583ea2b9?sel=6818f20654568865583ea2b9
The Python tests seem to require the User class to have a method called
inc_progress
, yet the user's progress is never directly updated. It is updated based on the rank of an activity the user completes. Thus the nameinc_progress
is very misleading and innapropriate. There should instead be a method calledcomplete_activity
that accepts the rank of the activity completed and internally calculates the user's progress. I find this "error" very unprofessional for someone who is at a level where they are writing katas.Haskell translation
Is every integer included in the test cases unique? If it is, it should probably be put in the description.
JavaScript:
JavaScript:
class
Position
object from the user fileRuby:
Position
from the user modulePython:
Position
from thesolution
moduleThis kata is a subject to deduplication process here: https://github.com/codewars/content-issues/issues/227.
Please join the discussion to help us identify duplicate kata and retire them.
This comment is hidden because it contains spoiler information about the solution
This comment is hidden because it contains spoiler information about the solution
this kata is outdated since JavaScript has had proper classes. it should either be retired or change every instance of "class-like" to "class"
Loading more items...