Ad
  • Default User Avatar
  • Custom User Avatar

    Description doesn't mention spaces at all ATM. That would be good to update as well then.

  • Custom User Avatar

    Except that spec is not part of the description, we are already using simplifications here and there, and the JS tests are not unordered either ( they could have been, with assertDeepEquals, but they are not, with assertSimilar ). Because JS does have something of an ordering in objects, at least sometimes ( and sometimes not ).

    It's a bit of a wasps' nest. But I tend towards wanting to preserve existing ordering, and the source has an ordering.

    ( I may not have thought of all this when translating or when having visions of nightmares. )

    Note that I don't get notifications for this thread. If the translation must be updated, please comment on the translation suggestion.

  • Custom User Avatar
  • Custom User Avatar

    js at least: missing a fixed test with a string beginning with a whitespace. Fortunately, it appears frequently in the random tests, but having it in the fixed tests would be more comfortable. Increasing a bit the number of random tests would be a good idea too, to be sure tha nobody can slip through the tests.

  • Default User Avatar

    That's a nightmare to test, at least in Haskell.

    Only because it uses the wrong type.
    https://tools.ietf.org/html/rfc8259

    An object is an unordered collection...

    It should be a Map in the first place.

  • Custom User Avatar

    Please not. That's a nightmare to test, at least in Haskell.

  • Custom User Avatar

    Fixed. I think.

    Is it OK now?

  • Custom User Avatar

    True and False are mentioned as result values, not input values. true and false ( and null ) are specified under value. These are intended as literal strings.

    This is consistent with normal JSON.

  • Custom User Avatar

    ( true, false and ) null is / are specified under value. These are intended as literal strings. This is not specific for Haskell either; it's in the shared part of the description.

  • Custom User Avatar

    The Haskell code block should not be visible in the JS version of the description.

  • Custom User Avatar

    No! ( This is why issues with translations should [ also ] be posted on the translation comment / suggestion. I did get a notification for this. )

    I'll have a look.

  • Custom User Avatar

    @johan: did you see the issues above?

  • Default User Avatar
  • Custom User Avatar

    Should tests ignore the order of pairs parsed in Object?

  • Loading more items...