I liked the kata but I agree, this part about always having a direction even when no keys are pressed at all and therefore there is no movement is weird. An invalid/uninitialized direction like e.g. -1 or 0 would have made the API clearer. The default UP direction does not make much sense either.
Hi @koba1996 - thanks so much for your interest in the kata and for translating!
I'm sure it's fine, given your level in Java, but as I don't use that language I'll wait if someone else can review it quickly. Otherwise I'll ask in Discord in 1-2 days if no-one sees your post directly.
see issue above
I liked the kata but I agree, this part about always having a direction even when no keys are pressed at all and therefore there is no movement is weird. An invalid/uninitialized direction like e.g.
-1or0would have made the API clearer. The defaultUPdirection does not make much sense either.both fixed
great, just solved it, thanks for the motivational speech ;)
Approved - thanks @koba1996 for translating and making the edits after the reviewing!
Hi @koba1996 - thanks so much for your interest in the kata and for translating!
I'm sure it's fine, given your level in Java, but as I don't use that language I'll wait if someone else can review it quickly. Otherwise I'll ask in Discord in 1-2 days if no-one sees your post directly.
Approved!
approved
Approved +1 Thanks
approved
Thanks!