Ad
  • Custom User Avatar

    You're welcome.

    But note that this kind of task has already been done to death, so even with all of the issues resolved, your kata might end up retired anyway (see the documentation, there is a part about "novel ideas" and retirement). You still can correct them and ask here for review, to see if you handle the things correctly, but I'd suggest you don't republish it (users can review and test drafts, but cannot submit solutions / note that you lose honor for each down vote your kata get, hence my suggestion).

    Your call. ;)
    Cheers

  • Custom User Avatar

    Thank you so much. I didnt know these things. My motivation was just learn how to write and publish kata. I will solve issues you wrote.

  • Custom User Avatar

    btw:

    Note : Tests are not case sensitive.

    The above implies that the user should make his code case insensitive. But there are no tests about that (which is also an issue). What you wanted to write was that "you do not have to worry about the case", or "only lowercase letters will be used".

  • Custom User Avatar

    Hi,

    Well... :/

    • no invalid case in the sample tests
    • no valid case in the full test suite
    • no random tests in the full test suite
    • the outputs aren't specified in the description
    • the outputs aren't consistent: valid! but invalid without exclamation mark while the user has to run the full test suite to know that
    • the output type doesn't make sense: the function should return a boolean, not strings (which is what the current description implies!)

    unpublishing.

    If you're interested in authoring kata, I strongly suggest that you read the whole documentation about it before your next attempt:
    https://docs.codewars.com/authoring/kata

    cheers

  • Custom User Avatar

    yeah ı got same issue. On intelij ı got correct pattern but for codewars my solution is wrong. I couldnt figure it out :/