It should be possible to run succeeding tests faster.
By delaying an initial run for a shorter period of time and running more repeat tests, non-memoising functions would consistently time-out but correctly memoised functions could return faster. That would improve the user experience. ( I am not at all a fan of test suites that take ~10 seconds, and I just don't think it's necessary here. ) You're running tens of thousands of tests in some cases, so large numbers of tests should not phase you.
That said, even with that improvement, I don't know if I'd be very satisfied with the kata. I think the approach of my kata, with a curried function decorated at every level, is simpler and works just as well. I'm also not a big fan of variadic functions, that may play into it.
This kata is more interesting and challenging as the other. I would not deem it a duplicate. But if they are considered to be too similar, I would opt for removing the other one and keeping this one instead.
I believe my kata has more strict requirements regarding function arguments and time complexity.
Those "strict requirements" should be in the specification. Also, given that a kata that covers the same exact idea already exists, the description should mention the difference between the two.
I haven't opened the trainer yet, so I'll just assume you know what you're doing.
This comment is hidden because it contains spoiler information about the solution
awesome kata
This comment has been reported as abusive
thank u. it was challenging but fun. interesting to see other's solutions. so diverse!
How about these types of solutions?
This comment is hidden because it contains spoiler information about the solution
I've added a note about it.
It should be possible to run succeeding tests faster.
By delaying an initial run for a shorter period of time and running more repeat tests, non-memoising functions would consistently time-out but correctly memoised functions could return faster. That would improve the user experience. ( I am not at all a fan of test suites that take ~10 seconds, and I just don't think it's necessary here. ) You're running tens of thousands of tests in some cases, so large numbers of tests should not phase you.
That said, even with that improvement, I don't know if I'd be very satisfied with the kata. I think the approach of my kata, with a curried function decorated at every level, is simpler and works just as well. I'm also not a big fan of variadic functions, that may play into it.
This kata is more interesting and challenging as the other. I would not deem it a duplicate. But if they are considered to be too similar, I would opt for removing the other one and keeping this one instead.
Fixed. Thanks!
The first description code block confuses
cubeanddouble.Oh, and
mDoublein the second block.ah great, good to know
Those "strict requirements" should be in the specification. Also, given that a kata that covers the same exact idea already exists, the description should mention the difference between the two.
I haven't opened the trainer yet, so I'll just assume you know what you're doing.
https://www.codewars.com/kata/reviews/525481903700c1a1ff0000e4/groups/5b12959dfe77c3f8fb000200
JSON.stringifyis not welcomed here :-)Loading more items...