He's talking about the starter code... the code that the user gets when they open the kata in the trainer for the first time. Here it is, I've replaced the trailing spaces with underscores:
Thank you, Kacarott for the clarification. I will try and fix these issues but it will take some time as Im moving very slowly today. But I will work on them one at a time. And natan, I will try to address these issues but please be patient. Ill post the edit link also though not sure how to do it using markdown. I will post each hopefully resolved issue after I have dealt with it.
1.Trailing spaces means a space at the end of a line, ie. after a semicolon or bracket
3.This means it is cut short and the remaining string replaced with "...". You can fix this by adding chai.config.truncateThreshold = 0; at the top of the tests (for both sample tests, and full tests)
trailing spaces? where do you mean? its standard to have them after commas.
i will add a fixed test with all digit groups included.
I dont understand. You mean something is omitted?
Im not sure what could be done about this though I know Ive had this same problem often when running tests for a kata i want to submit. You are welcome to edit this if youd like. ive left this kata open to editing by others.
empty string as input is more like error handling and I didnt want any of that in this kata.
I am running on very low energy as Im an elderly person and chonic pain issues and poor sleep, so if you decide to exit this kata yourself it is fine with me.
The last vowel not needing to be broken apart is the reason why the "The final result should have exactly one vowel per line." sentence is in the description. Since if there would be a line break after the last vowel, there would be no vowel in every line anymore
though unclear which
That's the reason why I included Merriam Webster's definition of when y count as a vowel:
The word has no other vowel
which I interpreted as "the word not having a, e, i, o, or u"
So for szyldyk (which I have replaced to szyldy due to @hobovsky pointing out that szyldyk doesn't actually exists), both ys count as vowels
My solution might have counted other characters as letters. So I replaced string.printable in the random tests with just ascii letters
I understand, I forked it and tried to fix most of the problems without modifying the original too much, I think in the end it didn't work out very well
I implemented your test cases, it seems reasonable, but it is generating a much larger amount of numbers that should be doubled, than tricky doubles, anyway
Fixed
Fixed
Oh my gosh. Thank you so much. I'll go right in and edit it. Try to keep that code clean.
He's talking about the starter code... the code that the user gets when they open the kata in the trainer for the first time. Here it is, I've replaced the trailing spaces with underscores:
I've spent over an hour looking for the spaces you mention but I can't find them. Where exactly are they and what do you mean by "initial code"?
okay. thank you, natan. appreciate your help in improving this kata. it just doesn't take much to overwhelm me lol
Thank you, Kacarott for the clarification. I will try and fix these issues but it will take some time as Im moving very slowly today. But I will work on them one at a time. And natan, I will try to address these issues but please be patient. Ill post the edit link also though not sure how to do it using markdown. I will post each hopefully resolved issue after I have dealt with it.
1.Trailing spaces means a space at the end of a line, ie. after a semicolon or bracket
3.This means it is cut short and the remaining string replaced with "...". You can fix this by adding
chai.config.truncateThreshold = 0;
at the top of the tests (for both sample tests, and full tests)I am running on very low energy as Im an elderly person and chonic pain issues and poor sleep, so if you decide to exit this kata yourself it is fine with me.
fixed, and also massively improved the random tests (they were expecting
0
most of the time) and added assertion mesagesfixed
I used string.printable instead of just ascii letters. Just using ascii letters for the random tests now ✅
Oh yeah and the 5th case is totally a problem on my solution. Will try to fix it
The last vowel not needing to be broken apart is the reason why the "The final result should have exactly one vowel per line." sentence is in the description. Since if there would be a line break after the last vowel, there would be no vowel in every line anymore
That's the reason why I included Merriam Webster's definition of when y count as a vowel:
which I interpreted as "the word not having a, e, i, o, or u"
So for szyldyk (which I have replaced to szyldy due to @hobovsky pointing out that szyldyk doesn't actually exists), both ys count as vowels
My solution might have counted other characters as letters. So I replaced string.printable in the random tests with just ascii letters
I understand, I forked it and tried to fix most of the problems without modifying the original too much, I think in the end it didn't work out very well
I implemented your test cases, it seems reasonable, but it is generating a much larger amount of numbers that should be doubled, than tricky doubles, anyway
Loading more items...