Ad
  • Default User Avatar

    That's something I didn't know, thanks! It's fixed now :)

  • Custom User Avatar

    .

  • Default User Avatar

    0 could be a good idea for the beauty of solutions.

  • Default User Avatar

    "Having a failure share representation with success can lead to failures accidentally being treated as success."
    If you can treat negative length of the side as a success it means you didn't understand the task. You can't have a piece of stick of a negative length.

    "If not knowing about the possible None, that is still better than not knowing about the possible -1, being forced to deal with it is the whole point."
    None can be an indicaion that there occured some case that your code didn't take care of. I still opt for -1 as an indication of no square case.

    "s/brake/break"
    I didn't understand it. Where is it? How did you come across it?

  • Default User Avatar

    I would like the output to remain integer.

    Both 0 and -1 make equal sense to me, both indicate that there can be no square constructed.

  • Custom User Avatar

    Or just 0 (would make sense)...

  • Custom User Avatar

    This comment is hidden because it contains spoiler information about the solution

  • Default User Avatar

    approved by someone

  • Custom User Avatar

    [list] + [list] is not tested.

  • Custom User Avatar

    It allows a different implementation of [list] + [list].

    Isn't that being tested?

  • Default User Avatar

    Thank you very much for your feedback.

    • The typos should be gone now.
    • I have added custom error messages just like you instructed me for the random tests (btw: now they look really cool :) )
    • Got rid of the sol global 'abomination' XD (I am kind of new to this, so I was not really sure why using a global var is so bad.)
    • The fixed tests are now really fixed
    • Random test cases are now under 'Random test cases'.

    Thanks again for the help.

  • Custom User Avatar

    The process of making an update kind of sets an expecation of getting everything right the first time and never changing your mind later

    A translation is essentially supposed to be just a "port" of the original - if you want to be more creative then you should author a new Kata ;-)

    Approved again.

  • Custom User Avatar

    Please fork, else I will mess it up. I don't know Haskell. I will approve asap.

  • Default User Avatar

    Thanks for the feedback! I can't seem to edit the test cases, though.

  • Custom User Avatar

    The point of contention is how to deal with females in the lineage. In particular, the question is whether the presence of a female...

    1. instantly disqualifies all further siblings of being considered a seventh son (this is the only bit the description describes)
    • 2a. instantly disqualifies all further siblings (male or female) of being the ancestors of any seventh sons (i.e. this particular branch in the tree is completely disregarded)
    • 2b. can the female herself be the ancestor of a line of seventh sons

    The random tests do not appropriately cover this (as can be seen in my solution, which terminates the search in a given branch if a female is found within the first 7 children of any given ancestor)

  • Loading more items...