Hi! Thanks for the translation. I'd like to approve it, but I have one or two questions...
I'd say moving test code into preloaded code is OK in case that test code is very complex or you want to hide some secrets.
But in this case, doTest just does the usual assertEquals. I think it's confusing to hide assertEquals behind Preloaded.doTest. You could simply inline all calls of Preloaded.doTest and remove the preloaded code.
This comment is hidden because it contains spoiler information about the solution
I don't remember. Probably ignoreCase = true;
https://devdocs.io/kotlin~1.8/api/latest/jvm/stdlib/kotlin.text/replace
what is
true
here for?need to sum not cound, wasted 30 minutes debuging, better read comments
Hi, totaly agree with you.
I've just forked someones solution.
Thank you for merging!)
Never mind, I'll just approve the translation and fix these little issues myself. :-) Thanks!
Hi! Thanks for the translation. I'd like to approve it, but I have one or two questions...
I'd say moving test code into preloaded code is OK in case that test code is very complex or you want to hide some secrets.
But in this case,
doTest
just does the usualassertEquals
. I think it's confusing to hideassertEquals
behindPreloaded.doTest
. You could simply inline all calls ofPreloaded.doTest
and remove the preloaded code.It's not a bug, it just performance test...
You went over primitive range.
For a new pple, exceptions should be created outside
SoulutionTest.class
like a regular multiple classes in one file.Hi, I think casting
n.toDouble()
and theni.toInt()
could be simplified.Check examples: