that will expect false, not true.
Here are the tests:
o1 = {name: 'Joe', surname: 'Smith'}; o2 = {name: 'Joe', surname: 'Smith'}; Test.assertEquals(deepCompare(o1,o2), true, 'should handle objects'); o1 = {name: 'Joe', surname: 'Smith'}; o2 = {surname: 'Smith', name: 'Joe'}; Test.assertEquals(deepCompare(o1,o2), true, 'property order should not matter'); o1 = {name: 'Joe', surname: 'Smith'}; o2 = {name: 'Joe'}; Test.assertEquals(deepCompare(o1,o2), false, 'should detect when a property is missing'); Test.assertEquals(deepCompare(o2,o1), false, 'should detect when a property is missing');
Why compare two of this objects must return true?? { name: 'Joe' } { name: 'Joe', surname: 'Smith' }
it's already enabled
Node 14.x should be enabled.
Node 14.x
This kata is one of only twenty-odd kata stuck in Node 10.x that are preventing removal of Node 10.x and Node 12.x; see https://github.com/codewars/content-issues/wiki/List-of-JavaScript-Kata-to-Update#list-of-node-10x-kata
Node 10.x
Node 12.x
Raising the issue instead of fixing it myself because (a) I haven't solved this kata and (b) I'm not sure it's worth it, seeing how it's languishing in Beta.
JS: Node v12 should be used enabled along with its appropiate assertion tools (Mocha + Chai).
I'd prefer the original one. I don't even know what "identity function" means.
Looks like someone had a bad day at work. Don't take it personally. Let the guy raise another 50 issues. Who cares.
Go raise that issue on the few thousands of other katas that dont have node 12 enabled then , i'm waiting :) you are so childish ^^
Pretty much a duplicate of these 2 katas.
Node 12 should be enabled.
The function name should be in camelCase.
The issue below is not fixed.
Learn how to use the test framework.
No they're not. The default error messages do not stringify arrays beyond a certain size.
The custom error messages are duplicating the default error messages, making the whole thing unreadable.
Loading collection data...
that will expect false, not true.
Here are the tests:
Why compare two of this objects must return true??
{ name: 'Joe' } { name: 'Joe', surname: 'Smith' }
it's already enabled
Node 14.x
should be enabled.This kata is one of only twenty-odd kata stuck in
Node 10.x
that are preventing removal ofNode 10.x
andNode 12.x
; see https://github.com/codewars/content-issues/wiki/List-of-JavaScript-Kata-to-Update#list-of-node-10x-kataRaising the issue instead of fixing it myself because (a) I haven't solved this kata and (b) I'm not sure it's worth it, seeing how it's languishing in Beta.
JS: Node v12 should be used enabled along with its appropiate assertion tools (Mocha + Chai).
I'd prefer the original one. I don't even know what "identity function" means.
Looks like someone had a bad day at work. Don't take it personally. Let the guy raise another 50 issues. Who cares.
Go raise that issue on the few thousands of other katas that dont have node 12 enabled then , i'm waiting :)
you are so childish ^^
Pretty much a duplicate of these 2 katas.
Node 12 should be enabled.
The function name should be in camelCase.
The issue below is not fixed.
Learn how to use the test framework.
No they're not. The default error messages do not stringify arrays beyond a certain size.
The custom error messages are duplicating the default error messages, making the whole thing unreadable.
Loading more items...